Small optimizations

Author: usercode

src/AsyncKeyLock.Benchmarks/AsyncKeyLock.Benchmarks.csproj

@@ -3,16 +3,16 @@
   <PropertyGroup>
     <TargetFramework>net8.0</TargetFramework>
     <ImplicitUsings>enable</ImplicitUsings>
-    <Nullable>enable</Nullable>
+    <Nullable>disable</Nullable>
     <OutputType>Exe</OutputType>
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="AsyncKeyedLock" Version="6.2.6" />
+    <PackageReference Include="AsyncKeyedLock" Version="6.3.4" />
     <PackageReference Include="BenchmarkDotNet" Version="0.13.12" />
     <PackageReference Include="NeoSmart.AsyncLock" Version="3.2.1" />
     <PackageReference Include="Nito.AsyncEx" Version="5.1.2" />
-    <PackageReference Include="SixLabors.ImageSharp.Web" Version="3.1.0" />
+    <PackageReference Include="SixLabors.ImageSharp.Web" Version="3.1.1" />
   </ItemGroup>
 
   <ItemGroup>

src/AsyncKeyLock.Benchmarks/BenchmarkSimpleWriterLock.cs

@@ -1,4 +1,5 @@
-using BenchmarkDotNet.Attributes;
+using AsyncKeyedLock;
+using BenchmarkDotNet.Attributes;
 using BenchmarkDotNet.Order;
 
 namespace AsyncKeyLock.Benchmarks;
@@ -13,11 +14,13 @@ public void GlobalSetup()
         _AsyncKeyLock = new AsyncLock();
         _NeoSmartLock = new NeoSmart.AsyncLock.AsyncLock();
         _NitoLock = new Nito.AsyncEx.AsyncLock();
+        _asyncNonKeyedLocker = new AsyncNonKeyedLocker();
     }
 
     private AsyncLock _AsyncKeyLock;
     private NeoSmart.AsyncLock.AsyncLock _NeoSmartLock;
     private Nito.AsyncEx.AsyncLock _NitoLock;
+    private AsyncNonKeyedLocker _asyncNonKeyedLocker;
 
     [Params(1_00, 1_000, 10_000)]
     public int NumberOfLocks;
@@ -57,4 +60,16 @@ public async Task Nito()
             }
         }
     }
+
+    [Benchmark]
+    public async Task AsyncNonKeyedLocker()
+    {
+        for (int i = 0; i < NumberOfLocks; i++)
+        {
+            using (await _asyncNonKeyedLocker.LockAsync())
+            {
+
+            }
+        }
+    }
 }

src/AsyncKeyLock.Benchmarks/Program.cs

@@ -1,4 +1,4 @@
 using AsyncKeyLock.Benchmarks;
 using BenchmarkDotNet.Running;
 
-BenchmarkRunner.Run<BenchmarkSimpleKeyLock>();
+BenchmarkRunner.Run<BenchmarkSimpleWriterLock>();

src/AsyncKeyLock.Tests/AsyncKeyLock.Tests.csproj

@@ -7,9 +7,9 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
-    <PackageReference Include="xunit" Version="2.6.5" />
-    <PackageReference Include="xunit.runner.visualstudio" Version="2.5.6">
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.9.0" />
+    <PackageReference Include="xunit" Version="2.7.0" />
+    <PackageReference Include="xunit.runner.visualstudio" Version="2.5.7">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
     </PackageReference>

src/AsyncKeyLock/AsyncKeyLock.csproj

@@ -34,7 +34,7 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="MinVer" Version="4.3.0">
+    <PackageReference Include="MinVer" Version="5.0.0">
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>

src/AsyncKeyLock/AsyncLock.cs

@@ -25,8 +25,8 @@ internal AsyncLock(object syncObject)
 
     internal readonly object SyncObj;
 
-    private readonly Queue<TaskCompletionSource<ReaderReleaser>> _waitingReaders = new Queue<TaskCompletionSource<ReaderReleaser>>();
-    private readonly Queue<TaskCompletionSource<WriterReleaser>> _waitingWriters = new Queue<TaskCompletionSource<WriterReleaser>>();
+    private readonly Queue<TaskCompletionSource<ReaderReleaser>> _waitingReaders = new();
+    private readonly Queue<TaskCompletionSource<WriterReleaser>> _waitingWriters = new();
 
     private readonly Task<ReaderReleaser> _readerReleaserTask;
     private readonly Task<WriterReleaser> _writerReleaserTask;

src/AsyncKeyLock/AsyncLock~.cs

@@ -15,7 +15,7 @@ public AsyncLock(int maxPoolSize = 64)
         _pool = new Pool<AsyncLock>(maxPoolSize);
     }
 
-    private readonly IDictionary<TKey, AsyncLock> _locks = new Dictionary<TKey, AsyncLock>();
+    private readonly Dictionary<TKey, AsyncLock> _locks = new();
     private readonly Pool<AsyncLock> _pool;
 
     /// <summary>

src/AsyncKeyLock/Pool.cs

@@ -9,7 +9,7 @@ namespace AsyncKeyLock;
 /// </summary>
 internal sealed class Pool<T>
 {
-    private readonly IList<T> _pool = new List<T>();
+    private readonly List<T> _pool = new();
     private readonly int MaxPoolSize;
 
     public Pool(int maxPoolSize = 64)