18 featbug update sst1 i0 correction #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BijalBPatel
added
bug
pbeaucage
approved these changes
Feb 15, 2023
There was a problem hiding this comment.
Thanks for doing all this detailed documentation work, this looks good to me.
It would be nice to have tests for this functionality.
But I don't see that this is going to break anything if we merge it now.
Assuming tests pass, this is OK to merge, we should keep an issue alive for testing.
Comment on lines
-67
to
+84
| self.dark_subtract=dark_subtract | ||
| self.dark_pedestal=dark_pedestal | ||
| self.exposure_offset=exposure_offset | ||
| self.dark_subtract = dark_subtract | ||
| self.dark_pedestal = dark_pedestal | ||
| self.exposure_offset = exposure_offset |
There was a problem hiding this comment.
We get it, the package is not fully flake8 compliant ;). No actual problem here, thanks for changing all this.
Co-authored-by: Peter Beaucage <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides an option for calibration mode = i0 which allows direct binning (skips the shutter thinning routine).
Also attempts to fix some xarray warnings that occur on running loadMd.
Additional flags added to loadRun and loadMd, but designed to not affect default behavior.
Introduces a new error that breaks the 'return_dataset' flag of loadrun, although metadata can be loaded without errors using loadMd.
Also added a lot of documentation to loadMd as part of understanding how it works.