-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat31 sst1 summarize bp #51
Conversation
Tagging issue #31 which didn't tag in title, weird. Will take a look soon. The CI failures appear to be an unrelated issue with Python3.8 and xarray. I will open a separate issue and get those fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really awesome! I made a few minor code style and functionality suggestions, and a suggestion to change the method signature. Let me know what you think.
One request that explicitly should not hold up merging: would you be willing to write a little how-to, largely adapted from the docstring, in the sphinx docs? If you can think of any ways this method might be unit-tested it would be good to document them as well. Logistically we actually can't unit test this class until there is a public BNL Tiled server, though we could ask Dan Allan to add a rsoxs example to the public Tiled demonstration server. That wouldn't get us a rsoxs catalog, though. |
|
Woops - sorry for close/opening, meant to just reply to a comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
No problem - unless someone else gets to it first, I'll take a crack at the sphinx documentation and tests in a couple of weeks. |
Expanded functionality of the summarize_run function in SST1RSiXSDB.py (#31). I believe the signature matches that of the old version, so existing code should remain functional.
New Features:
See signature docstring for full documentation and example functions.