Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary files written during tests #60

Open
wd15 opened this issue May 20, 2020 · 0 comments
Open

Unnecessary files written during tests #60

wd15 opened this issue May 20, 2020 · 0 comments

Comments

@wd15
Copy link
Collaborator

wd15 commented May 20, 2020 •
edited
Loading

The following files are written to the working directory when running the tests

jarvis/db/jdft_2d-4-26-2020.json
jarvis/db/jdft_3d-4-26-2020.json
jarvis/db/jff1.json
jarvis/db/jml_3d-4-26-2020.json
jarvis/examples/vasp/SiOptb88/CHGCAR

It might be better to write those to a temporary directory that's written and read from within a context manager so they are always deleted even if the test suite doesn't finish or something goes wrong. py.test and flask have things to help with that during testing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wd15