Skip to content

Rename make-row to clarify intent in cables module #51

@oubiwann

Description

@oubiwann

Problem

In underack.cables, the function make-row creates a tuple representing a pub/sub connection:

(defun make-row (publisher subscriber)
  "Pubsub terminology is used here..."
  \`#(,publisher ,subscriber))

The name "row" suggests database/table thinking, but the actual concept is a connection or subscription between modules.

Suggested Fix

Rename to better reflect the domain:

  • make-connection
  • make-subscription
  • make-cable (matching the module name)

Update all call sites accordingly.

File

src/underack/cables.lfe

Priority

P2 - Naming clarity, can be done alongside other cables work.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions