adapt-wasm32-without-fmt

EthanYuan · EthanYuan · commit 6bda55e6f589 · 2025-06-10T12:14:47.000+08:00
diff --git a/Cargo.toml b/Cargo.toml
@@ -5,6 +5,7 @@ resolver = "2"
 # as in `ci/ci-tests.sh`.
 members = [
     "lightning",
+    "lightning-common",
     "lightning-types",
     "lightning-block-sync",
     "lightning-invoice",
diff --git a/lightning-background-processor/Cargo.toml b/lightning-background-processor/Cargo.toml
@@ -25,6 +25,7 @@ bitcoin_hashes = { version = "0.14.0", default-features = false }
 bitcoin-io = { version = "0.1.2", default-features = false }
 lightning = { version = "0.1.0", path = "../lightning", default-features = false }
 lightning-rapid-gossip-sync = { version = "0.1.0", path = "../lightning-rapid-gossip-sync", default-features = false }
+lightning-common = { path = "../lightning-common" }
 
 [dev-dependencies]
 tokio = { version = "1.35", features = [ "macros", "rt", "rt-multi-thread", "sync", "time" ] }
diff --git a/lightning-background-processor/src/lib.rs b/lightning-background-processor/src/lib.rs
@@ -48,11 +48,11 @@ use core::time::Duration;
 #[cfg(feature = "std")]
 use core::sync::atomic::{AtomicBool, Ordering};
 #[cfg(feature = "std")]
+use lightning_common::Instant;
+#[cfg(feature = "std")]
 use std::sync::Arc;
 #[cfg(feature = "std")]
 use std::thread::{self, JoinHandle};
-#[cfg(feature = "std")]
-use std::time::Instant;
 
 #[cfg(not(feature = "std"))]
 use alloc::boxed::Box;
@@ -948,7 +948,7 @@ impl BackgroundProcessor {
 					handle_network_graph_update(network_graph, &event)
 				}
 				if let Some(ref scorer) = scorer {
-					use std::time::SystemTime;
+					use lightning_common::SystemTime;
 					let duration_since_epoch = SystemTime::now()
 						.duration_since(SystemTime::UNIX_EPOCH)
 						.expect("Time should be sometime after 1970");
@@ -995,7 +995,7 @@ impl BackgroundProcessor {
 				|time: &Instant, dur| time.elapsed().as_secs() > dur,
 				false,
 				|| {
-					use std::time::SystemTime;
+					use lightning_common::SystemTime;
 					Some(
 						SystemTime::now()
 							.duration_since(SystemTime::UNIX_EPOCH)
diff --git a/lightning-common/Cargo.toml b/lightning-common/Cargo.toml
@@ -0,0 +1,12 @@
+[package]
+name = "lightning-common"
+version = "0.1.0"
+edition = "2021"
+
+[dependencies]
+
+[target.'cfg(target_arch = "wasm32")'.dependencies]
+web-time = "1.1"
+
+[lints]
+workspace = true
diff --git a/lightning-common/src/lib.rs b/lightning-common/src/lib.rs
@@ -0,0 +1,4 @@
+#[cfg(not(target_arch = "wasm32"))]
+pub use std::time::{Duration, Instant, SystemTime, UNIX_EPOCH};
+#[cfg(target_arch = "wasm32")]
+pub use web_time::{Duration, Instant, SystemTime, UNIX_EPOCH};
diff --git a/lightning-dns-resolver/Cargo.toml b/lightning-dns-resolver/Cargo.toml
@@ -10,6 +10,7 @@ edition = "2021"
 [dependencies]
 lightning = { version = "0.1.0", path = "../lightning", default-features = false }
 lightning-types = { version = "0.2.0", path = "../lightning-types", default-features = false }
+lightning-common = { path = "../lightning-common" }
 dnssec-prover = { version = "0.6", default-features = false, features = [ "std", "tokio" ] }
 tokio = { version = "1.0", default-features = false, features = ["rt"] }
 
diff --git a/lightning-invoice/Cargo.toml b/lightning-invoice/Cargo.toml
@@ -20,6 +20,7 @@ std = []
 [dependencies]
 bech32 = { version = "0.11.0", default-features = false }
 lightning-types = { version = "0.2.0", path = "../lightning-types", default-features = false }
+lightning-common = { path = "../lightning-common" }
 serde = { version = "1.0.118", optional = true }
 bitcoin = { version = "0.32.2", default-features = false, features = ["secp-recovery"] }
 
diff --git a/lightning-invoice/src/lib.rs b/lightning-invoice/src/lib.rs
@@ -28,7 +28,7 @@ extern crate lightning_types;
 extern crate serde;
 
 #[cfg(feature = "std")]
-use std::time::SystemTime;
+use lightning_common::SystemTime;
 
 use bech32::primitives::decode::CheckedHrpstringError;
 use bech32::{Checksum, Fe32};
diff --git a/lightning-liquidity/Cargo.toml b/lightning-liquidity/Cargo.toml
@@ -22,6 +22,7 @@ backtrace = ["dep:backtrace"]
 lightning = { version = "0.1.0", path = "../lightning", default-features = false }
 lightning-types = { version = "0.2.0", path = "../lightning-types", default-features = false }
 lightning-invoice = { version = "0.33.0", path = "../lightning-invoice", default-features = false, features = ["serde"] }
+lightning-common = { path = "../lightning-common" }
 
 bitcoin = { version = "0.32.2", default-features = false, features = ["serde"] }
 
diff --git a/lightning-liquidity/src/lsps2/utils.rs b/lightning-liquidity/src/lsps2/utils.rs
@@ -8,7 +8,7 @@ use bitcoin::hashes::sha256::Hash as Sha256;
 use bitcoin::hashes::{Hash, HashEngine};
 
 #[cfg(feature = "std")]
-use std::time::{SystemTime, UNIX_EPOCH};
+use lightning_common::{SystemTime, UNIX_EPOCH};
 
 /// Determines if the given parameters are valid given the secret used to generate the promise.
 pub fn is_valid_opening_fee_params(
diff --git a/lightning-rapid-gossip-sync/Cargo.toml b/lightning-rapid-gossip-sync/Cargo.toml
@@ -15,6 +15,7 @@ std = ["bitcoin-io/std", "bitcoin_hashes/std"]
 
 [dependencies]
 lightning = { version = "0.1.0", path = "../lightning", default-features = false }
+lightning-common = { path = "../lightning-common" }
 bitcoin = { version = "0.32.2", default-features = false }
 bitcoin_hashes = { version = "0.14.0", default-features = false }
 bitcoin-io = { version = "0.1.2", default-features = false }
diff --git a/lightning-rapid-gossip-sync/src/processing.rs b/lightning-rapid-gossip-sync/src/processing.rs
@@ -18,7 +18,7 @@ use lightning::{log_debug, log_given_level, log_gossip, log_trace, log_warn};
 use crate::{GraphSyncError, RapidGossipSync};
 
 #[cfg(all(feature = "std", not(test)))]
-use std::time::{SystemTime, UNIX_EPOCH};
+use lightning_common::{SystemTime, UNIX_EPOCH};
 
 #[cfg(all(not(feature = "std"), not(test)))]
 use alloc::{borrow::ToOwned, vec::Vec};
diff --git a/lightning-transaction-sync/Cargo.toml b/lightning-transaction-sync/Cargo.toml
@@ -25,6 +25,7 @@ async-interface = []
 [dependencies]
 lightning = { version = "0.1.0", path = "../lightning", default-features = false, features = ["std"] }
 lightning-macros = { version = "0.1", path = "../lightning-macros", default-features = false }
+lightning-common = { path = "../lightning-common" }
 bitcoin = { version = "0.32.2", default-features = false }
 futures = { version = "0.3", optional = true }
 esplora-client = { version = "0.11", default-features = false, optional = true }
diff --git a/lightning-transaction-sync/src/electrum.rs b/lightning-transaction-sync/src/electrum.rs
@@ -20,10 +20,10 @@ use lightning::{log_debug, log_error, log_trace};
 use bitcoin::block::Header;
 use bitcoin::{BlockHash, Script, Transaction, Txid};
 
+use lightning_common::Instant;
 use std::collections::HashSet;
 use std::ops::Deref;
 use std::sync::Mutex;
-use std::time::Instant;
 
 /// Synchronizes LDK with a given Electrum server.
 ///
diff --git a/lightning-transaction-sync/src/esplora.rs b/lightning-transaction-sync/src/esplora.rs
@@ -100,7 +100,7 @@ where
 
 		log_trace!(self.logger, "Starting transaction sync.");
 		#[cfg(feature = "time")]
-		let start_time = std::time::Instant::now();
+		let start_time = lightning_common::Instant::now();
 		let mut num_confirmed = 0;
 		let mut num_unconfirmed = 0;
 
diff --git a/lightning/Cargo.toml b/lightning/Cargo.toml
@@ -35,6 +35,7 @@ default = ["std", "grind_signatures"]
 [dependencies]
 lightning-types = { version = "0.2.0", path = "../lightning-types", default-features = false }
 lightning-invoice = { version = "0.33.0", path = "../lightning-invoice", default-features = false }
+lightning-common = { path = "../lightning-common" }
 
 bech32 = { version = "0.11.0", default-features = false }
 bitcoin = { version = "0.32.2", default-features = false, features = ["secp-recovery"] }
diff --git a/lightning/src/ln/channelmanager.rs b/lightning/src/ln/channelmanager.rs
@@ -6674,8 +6674,8 @@ where
 			}
 
 			#[cfg(feature = "std")]
-			let duration_since_epoch = std::time::SystemTime::now()
-				.duration_since(std::time::SystemTime::UNIX_EPOCH)
+			let duration_since_epoch = lightning_common::SystemTime::now()
+				.duration_since(lightning_common::SystemTime::UNIX_EPOCH)
 				.expect("SystemTime::now() should come after SystemTime::UNIX_EPOCH");
 			#[cfg(not(feature = "std"))]
 			let duration_since_epoch = Duration::from_secs(
@@ -9715,7 +9715,7 @@ This indicates a bug inside LDK. Please report this error at https://github.com/
 
 		#[cfg(feature = "std")]
 		let duration_since_epoch = {
-			use std::time::SystemTime;
+			use lightning_common::SystemTime;
 			SystemTime::now().duration_since(SystemTime::UNIX_EPOCH)
 				.expect("SystemTime::now() should be after SystemTime::UNIX_EPOCH")
 		};
@@ -10450,8 +10450,8 @@ where
 			self.highest_seen_timestamp.load(Ordering::Acquire) as u64
 		);
 		#[cfg(feature = "std")]
-		let now = std::time::SystemTime::now()
-			.duration_since(std::time::SystemTime::UNIX_EPOCH)
+		let now = lightning_common::SystemTime::now()
+			.duration_since(lightning_common::SystemTime::UNIX_EPOCH)
 			.expect("SystemTime::now() should come after SystemTime::UNIX_EPOCH");
 
 		now
diff --git a/lightning/src/ln/outbound_payment.rs b/lightning/src/ln/outbound_payment.rs
@@ -28,9 +28,9 @@ use crate::routing::router::{BlindedTail, InFlightHtlcs, Path, PaymentParameters
 use crate::sign::{EntropySource, NodeSigner, Recipient};
 use crate::util::errors::APIError;
 use crate::util::logger::Logger;
+use crate::util::ser::ReadableArgs;
 #[cfg(feature = "std")]
 use crate::util::time::Instant;
-use crate::util::ser::ReadableArgs;
 
 #[cfg(async_payments)]
 use {
@@ -388,7 +388,7 @@ impl Retry {
 #[cfg(feature = "std")]
 pub(super) fn has_expired(route_params: &RouteParameters) -> bool {
 	if let Some(expiry_time) = route_params.payment_params.expiry_time {
-		if let Ok(elapsed) = std::time::SystemTime::UNIX_EPOCH.elapsed() {
+		if let Ok(elapsed) = lightning_common::SystemTime::UNIX_EPOCH.elapsed() {
 			return elapsed > core::time::Duration::from_secs(expiry_time)
 		}
 	}
@@ -2496,7 +2496,8 @@ mod tests {
 		let secp_ctx = Secp256k1::new();
 		let keys_manager = test_utils::TestKeysInterface::new(&[0; 32], Network::Testnet);
 
-		let past_expiry_time = std::time::SystemTime::UNIX_EPOCH.elapsed().unwrap().as_secs() - 2;
+		let past_expiry_time =
+			lightning_common::SystemTime::UNIX_EPOCH.elapsed().unwrap().as_secs() - 2;
 		let payment_params = PaymentParameters::from_node_id(
 				PublicKey::from_secret_key(&secp_ctx, &SecretKey::from_slice(&[42; 32]).unwrap()),
 				0
diff --git a/lightning/src/ln/payment_tests.rs b/lightning/src/ln/payment_tests.rs
@@ -48,7 +48,7 @@ use crate::routing::gossip::NodeId;
 #[cfg(feature = "std")]
 use {
 	crate::util::time::Instant as TestTime,
-	std::time::{SystemTime, Instant, Duration},
+	lightning_common::{SystemTime, Instant, Duration},
 };
 
 #[test]
diff --git a/lightning/src/ln/peer_handler.rs b/lightning/src/ln/peer_handler.rs
@@ -1750,7 +1750,7 @@ impl<Descriptor: SocketDescriptor, CM: Deref, RM: Deref, OM: Deref, L: Deref, CM
 				{
 					// Forward ad-hoc gossip if the timestamp range is less than six hours ago.
 					// Otherwise, do a full sync.
-					use std::time::{SystemTime, UNIX_EPOCH};
+					use lightning_common::{SystemTime, UNIX_EPOCH};
 					let full_sync_threshold = SystemTime::now().duration_since(UNIX_EPOCH).expect("Time must be > 1970").as_secs() - 6 * 3600;
 					if (_msg.first_timestamp as u64) > full_sync_threshold {
 						should_do_full_sync = false;
@@ -3018,7 +3018,7 @@ mod tests {
 		// Until we have std::thread::scoped we have to unsafe { turn off the borrow checker }.
 		let peers = Arc::new(create_network(2, unsafe { &*(&*cfgs as *const _) as &'static _ }));
 
-		let start_time = std::time::Instant::now();
+		let start_time = lightning_common::Instant::now();
 		macro_rules! spawn_thread { ($id: expr) => { {
 			let peers = Arc::clone(&peers);
 			let cfgs = Arc::clone(&cfgs);
@@ -3593,7 +3593,7 @@ mod tests {
 	#[test]
 	#[cfg(feature = "std")]
 	fn test_process_events_multithreaded() {
-		use std::time::{Duration, Instant};
+		use lightning_common::{Duration, Instant};
 		// `process_events` shouldn't block on another thread processing events and instead should
 		// simply signal the currently processing thread to go around the loop again.
 		// Here we test that this happens by spawning a few threads and checking that we see one go
diff --git a/lightning/src/offers/invoice.rs b/lightning/src/offers/invoice.rs
@@ -136,7 +136,7 @@ use crate::util::string::PrintableString;
 use crate::prelude::*;
 
 #[cfg(feature = "std")]
-use std::time::SystemTime;
+use lightning_common::SystemTime;
 
 pub(crate) const DEFAULT_RELATIVE_EXPIRY: Duration = Duration::from_secs(7200);
 
diff --git a/lightning/src/offers/invoice_request.rs b/lightning/src/offers/invoice_request.rs
@@ -699,8 +699,8 @@ macro_rules! invoice_request_respond_with_explicit_signing_pubkey_methods { (
 	pub fn respond_with(
 		&$self, payment_paths: Vec<BlindedPaymentPath>, payment_hash: PaymentHash
 	) -> Result<$builder, Bolt12SemanticError> {
-		let created_at = std::time::SystemTime::now()
-			.duration_since(std::time::SystemTime::UNIX_EPOCH)
+		let created_at = lightning_common::SystemTime::now()
+			.duration_since(lightning_common::SystemTime::UNIX_EPOCH)
 			.expect("SystemTime::now() should come after SystemTime::UNIX_EPOCH");
 
 		$contents.respond_with_no_std(payment_paths, payment_hash, created_at)
@@ -883,8 +883,8 @@ macro_rules! invoice_request_respond_with_derived_signing_pubkey_methods { (
 	pub fn respond_using_derived_keys(
 		&$self, payment_paths: Vec<BlindedPaymentPath>, payment_hash: PaymentHash
 	) -> Result<$builder, Bolt12SemanticError> {
-		let created_at = std::time::SystemTime::now()
-			.duration_since(std::time::SystemTime::UNIX_EPOCH)
+		let created_at = lightning_common::SystemTime::now()
+			.duration_since(lightning_common::SystemTime::UNIX_EPOCH)
 			.expect("SystemTime::now() should come after SystemTime::UNIX_EPOCH");
 
 		$self.respond_using_derived_keys_no_std(payment_paths, payment_hash, created_at)
diff --git a/lightning/src/offers/offer.rs b/lightning/src/offers/offer.rs
@@ -111,7 +111,7 @@ use {
 use crate::prelude::*;
 
 #[cfg(feature = "std")]
-use std::time::SystemTime;
+use lightning_common::SystemTime;
 use bitcoin::hex::impl_fmt_traits;
 
 pub(super) const IV_BYTES_WITH_METADATA: &[u8; IV_LEN] = b"LDK Offer ~~~~~~";
diff --git a/lightning/src/offers/refund.rs b/lightning/src/offers/refund.rs
@@ -120,7 +120,7 @@ use {
 use crate::prelude::*;
 
 #[cfg(feature = "std")]
-use std::time::SystemTime;
+use lightning_common::SystemTime;
 
 pub(super) const IV_BYTES_WITH_METADATA: &[u8; IV_LEN] = b"LDK Refund ~~~~~";
 pub(super) const IV_BYTES_WITHOUT_METADATA: &[u8; IV_LEN] = b"LDK Refund v2~~~";
@@ -560,8 +560,8 @@ macro_rules! respond_with_explicit_signing_pubkey_methods { ($self: ident, $buil
 		&$self, payment_paths: Vec<BlindedPaymentPath>, payment_hash: PaymentHash,
 		signing_pubkey: PublicKey,
 	) -> Result<$builder, Bolt12SemanticError> {
-		let created_at = std::time::SystemTime::now()
-			.duration_since(std::time::SystemTime::UNIX_EPOCH)
+		let created_at = lightning_common::SystemTime::now()
+			.duration_since(lightning_common::SystemTime::UNIX_EPOCH)
 			.expect("SystemTime::now() should come after SystemTime::UNIX_EPOCH");
 
 		$self.respond_with_no_std(payment_paths, payment_hash, signing_pubkey, created_at)
@@ -618,8 +618,8 @@ macro_rules! respond_with_derived_signing_pubkey_methods { ($self: ident, $build
 	where
 		ES::Target: EntropySource,
 	{
-		let created_at = std::time::SystemTime::now()
-			.duration_since(std::time::SystemTime::UNIX_EPOCH)
+		let created_at = lightning_common::SystemTime::now()
+			.duration_since(lightning_common::SystemTime::UNIX_EPOCH)
 			.expect("SystemTime::now() should come after SystemTime::UNIX_EPOCH");
 
 		$self.respond_using_derived_keys_no_std(
diff --git a/lightning/src/offers/test_utils.rs b/lightning/src/offers/test_utils.rs
@@ -106,8 +106,8 @@ pub(crate) fn payment_hash() -> PaymentHash {
 }
 
 pub(crate) fn now() -> Duration {
-	std::time::SystemTime::now()
-		.duration_since(std::time::SystemTime::UNIX_EPOCH)
+	lightning_common::SystemTime::now()
+		.duration_since(lightning_common::SystemTime::UNIX_EPOCH)
 		.expect("SystemTime::now() should come after SystemTime::UNIX_EPOCH")
 }
 
diff --git a/lightning/src/routing/gossip.rs b/lightning/src/routing/gossip.rs
@@ -55,7 +55,7 @@ use core::{cmp, fmt};
 pub use lightning_types::routing::RoutingFees;
 
 #[cfg(feature = "std")]
-use std::time::{SystemTime, UNIX_EPOCH};
+use lightning_common::{SystemTime, UNIX_EPOCH};
 
 /// We remove stale channel directional info two weeks after the last update, per BOLT 7's
 /// suggestion.
@@ -3033,7 +3033,7 @@ pub(crate) mod tests {
 
 		#[cfg(feature = "std")]
 		{
-			use std::time::{SystemTime, UNIX_EPOCH};
+			use lightning_common::{SystemTime, UNIX_EPOCH};
 
 			let tracking_time = SystemTime::now()
 				.duration_since(UNIX_EPOCH)
@@ -3485,7 +3485,7 @@ pub(crate) mod tests {
 
 		#[cfg(feature = "std")]
 		{
-			use std::time::{SystemTime, UNIX_EPOCH};
+			use lightning_common::{SystemTime, UNIX_EPOCH};
 
 			let tracking_time = SystemTime::now()
 				.duration_since(UNIX_EPOCH)
diff --git a/lightning/src/util/test_utils.rs b/lightning/src/util/test_utils.rs
@@ -1070,7 +1070,7 @@ impl msgs::RoutingMessageHandler for TestRoutingMessageHandler {
 		let mut gossip_start_time = 0;
 		#[cfg(feature = "std")]
 		{
-			use std::time::{SystemTime, UNIX_EPOCH};
+			use lightning_common::{SystemTime, UNIX_EPOCH};
 			gossip_start_time = SystemTime::now().duration_since(UNIX_EPOCH).expect("Time must be > 1970").as_secs();
 			if self.request_full_sync.load(Ordering::Acquire) {
 				gossip_start_time -= 60 * 60 * 24 * 7 * 2; // 2 weeks ago
diff --git a/lightning/src/util/time.rs b/lightning/src/util/time.rs
@@ -10,7 +10,7 @@
 #[cfg(test)]
 pub use test::Instant;
 #[cfg(not(test))]
-pub use std::time::Instant;
+pub use lightning_common::Instant;
 
 #[cfg(test)]
 mod test {
