mv: create the cross-device destination exclusively and chown it by fd

Author: krosci

.github/workflows/CICD.yml

@@ -876,7 +876,7 @@ jobs:
           - { os: ubuntu-latest, features: "md5sum,sha1sum,sha224sum,sha256sum,sha384sum,sha512sum,cksum,openssl" }
           # macOS: vendored only — system libcrypto needs OPENSSL_DIR
           # pointing at Homebrew, which isn't worth wiring up for a smoke test.
-          # MinGW(UCRT): done at make.yml as actual consumer is MSYS2 only
+          # todo: check Windows (MinGW's system openssl)
     steps:
     - uses: actions/checkout@v7
       with:

.github/workflows/GnuComment.yml

@@ -17,9 +17,7 @@ jobs:
 
     runs-on: ubuntu-latest
     if: >
-      github.event.workflow_run.event == 'pull_request' &&
-      (github.event.workflow_run.conclusion == 'success' ||
-       github.event.workflow_run.conclusion == 'failure')
+      github.event.workflow_run.event == 'pull_request'
     steps:
       - name: 'Download artifact'
         uses: actions/github-script@v9
@@ -36,10 +34,6 @@ jobs:
             var matchArtifact = artifacts.data.artifacts.filter((artifact) => {
               return artifact.name == "comment"
             })[0];
-            if (!matchArtifact) {
-              core.info("No comment artifact found; skipping.");
-              return;
-            }
             var download = await github.rest.actions.downloadArtifact({
               owner: context.repo.owner,
               repo: context.repo.repo,

.github/workflows/GnuTests.yml

@@ -40,7 +40,7 @@ env:
 jobs:
   native:
     name: Run GNU tests (native)
-    runs-on: ubuntu-26.04 # some strace? test needs newer glibc
+    runs-on: ubuntu-24.04
     steps:
     #### Get the code
     - name: Checkout code (uutils)

.github/workflows/freebsd.yml

@@ -41,7 +41,7 @@ jobs:
         sync: rsync
         copyback: false
         # We need jq and GNU coreutils to run show-utils.sh and bash to use inline shell string replacement
-        prepare: pkg install -y rust sudo jaq coreutils bash python3
+        prepare: pkg install -y curl sudo jaq coreutils bash python3
         run: |
           ## Prepare, build, and test
           sudo ln -s $(command -v jaq) /usr/local/bin/jq
@@ -62,6 +62,9 @@ jobs:
           sudo -i -u ${TEST_USER} bash << EOF
           set -e
           whoami
+          curl https://sh.rustup.rs -sSf --output rustup.sh
+          sh rustup.sh -y -c rustfmt,clippy --profile=minimal -t stable
+          . ${HOME}/.cargo/env
           ## VARs setup
           cd "${WORKSPACE}"
           unset FAIL_ON_FAULT ; case '${{ env.STYLE_FAIL_ON_FAULT }}' in
@@ -131,7 +134,7 @@ jobs:
         usesh: true
         sync: rsync
         copyback: false
-        prepare: pkg install -y gmake nextest rust sudo jaq
+        prepare: pkg install -y curl gmake sudo jaq
         run: |
           ## Prepare, build, and test
           sudo ln -s $(command -v jaq) /usr/local/bin/jq
@@ -155,6 +158,12 @@ jobs:
           sudo -i -u ${TEST_USER} sh << EOF
           set -e
           whoami
+          curl https://sh.rustup.rs -sSf --output rustup.sh
+          sh rustup.sh -y --profile=minimal
+          . $HOME/.cargo/env
+          # Install nextest
+          mkdir -p ~/.cargo/bin
+          curl -LsSf https://get.nexte.st/latest/freebsd | tar zxf - -C ~/.cargo/bin
           ## Info
           # environment
           echo "## environment"
@@ -176,8 +185,6 @@ jobs:
           unset FAULT
           export CARGO_INCREMENTAL=0
           export RUSTFLAGS="-C strip=symbols" # for disk space
-          # vendored OpenSSL takes many times to build. Use system one (LibreSSL is supported).
-          export OPENSSL_NO_VENDOR=1 OPENSSL_DIR=/usr
           cargo build || FAULT=1
           export PATH=~/.cargo/bin:${PATH}
           export RUST_BACKTRACE=1

.github/workflows/make.yml

@@ -311,16 +311,15 @@ jobs:
       # Upgrading it mid-session changes the shared memory layout (60344 -> 59320),
       # which causes subsequent fork() calls to fail with EAGAIN (exit code 254).
       shell: 'C:\msys64\usr\bin\bash.exe --login -eo pipefail {0}'
-      # test Cygwin & MinGW(UCRT) instead of pre-installed Rust.
       run: |
-        pacman -Sy --noconfirm --needed base-devel libopenssl make openssl-devel pkgconf rust \
-          mingw-w64-ucrt-x86_64-openssl mingw-w64-ucrt-x86_64-rust
+        pacman -Sy --noconfirm --needed base-devel libopenssl make openssl-devel pkgconf rust
       env:
         CHERE_INVOKING: 1
     - name: "`(x86_64-pc-cygwin) make install PROG_PREFIX=uu- PROFILE=release-small COMPLETIONS=n MANPAGES=n LOCALES=n`"
       shell: 'C:\msys64\usr\bin\bash.exe --login -eo pipefail {0}'
       run: |
         set -x
+        export OPENSSL_NO_VENDOR=1
         export CARGOFLAGS="--features openssl"
         DESTDIR=/tmp/c make install PROG_PREFIX=uu- PROFILE=release-small COMPLETIONS=n MANPAGES=n LOCALES=n
         # Check that cksum is linked with openssl (e.g. msys-crypto-*.dll)
@@ -340,7 +339,6 @@ jobs:
         bsdtar -caf x86_64-pc-cygwin.tar.zst -C /tmp/c/usr/local bin
       env:
         CHERE_INVOKING: 1
-        OPENSSL_NO_VENDOR: "1"
         RUST_BACKTRACE: "1"
     - name: Publish
       uses: softprops/action-gh-release@v3
@@ -353,21 +351,14 @@ jobs:
           individual-x86_64-pc-cygwin.tar.zst
       env:
         GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-    - name: "`make install` (MinGW UCRT)"
-      shell: 'C:\msys64\usr\bin\bash.exe --login -eo pipefail {0}'
-      env:
-        CHERE_INVOKING: 1
-        MSYSTEM: "UCRT64"
-        OPENSSL_DIR: "/ucrt64"
-        OPENSSL_NO_VENDOR: "1"
-        OPENSSL_STATIC: "0"
+    - name: "`make install`"
+      shell: bash
       run: |
         set -x
-        export CARGOFLAGS="--features openssl"
         # Check that we exclude unix programs to avoid build failure
         # Windows's stdbuf depends on Cygwin's libstdbuf. So make should not try to install libstdbuf
         make install DESTDIR=/tmp/w PREFIX=/tmp/usr MULTICALL=y COMPLETIONS=n MANPAGES=n LOCALES=n \
-         SKIP_UTILS="arch b2sum base32 base64 basename basenc cat comm cp csplit cut date dd df dir dircolors dirname du echo env expand expr factor false fmt fold head hostname hostid join link ln ls md5sum mkdir mktemp more mv nl nproc numfmt od paste pathchk pr printenv printf ptx pwd readlink realpath rm rmdir seq sha1sum sha224sum sha256sum sha384sum sha512sum shred shuf sleep sort split sum sync tac tail tee test touch tr true truncate tsort tty uname unexpand uniq unlink vdir wc whoami yes"
+         SKIP_UTILS="arch b2sum base32 base64 basename basenc cat cksum comm cp csplit cut date dd df dir dircolors dirname du echo env expand expr factor false fmt fold head hostname hostid join link ln ls md5sum mkdir mktemp more mv nl nproc numfmt od paste pathchk pr printenv printf ptx pwd readlink realpath rm rmdir seq sha1sum sha224sum sha256sum sha384sum sha512sum shred shuf sleep sort split sum sync tac tail tee test touch tr true truncate tsort tty uname unexpand uniq unlink vdir wc whoami yes"
         target/release/coreutils.exe stdbuf --version
 
   test_busybox:

.github/workflows/openbsd.yml

@@ -72,6 +72,9 @@ jobs:
           sudo -i -u ${TEST_USER} bash << EOF
           set -e
           whoami
+          # Rust is installed from packages, no need for rustup
+          # Set up PATH for cargo
+          export PATH="/usr/local/bin:$PATH"
           ## VARs setup
           cd "${WORKSPACE}"
           unset FAIL_ON_FAULT ; case '${{ env.STYLE_FAIL_ON_FAULT }}' in
@@ -182,8 +185,12 @@ jobs:
           whoami
           # Increase max open files (512 by default)
           ulimit -n 1024
-          # todo: install nextest if official OpenBSD package was provided
-          # Use regular cargo test currently
+          # Rust is installed from packages, no need for rustup
+          # Set up PATH for cargo
+          export PATH="/usr/local/bin:$PATH"
+          # Install nextest
+          mkdir -p ~/.cargo/bin
+          # Note: nextest might not have OpenBSD builds, so we'll use regular cargo test
           ## Info
           echo "::group::environment"
           echo "CI='${CI}'"
@@ -203,12 +210,11 @@ jobs:
           cd "${WORKSPACE}"
           unset FAULT
           # openbsd is very slow. Omit duplicated cargo build and do test only
+          export PATH=~/.cargo/bin:${PATH}
           export RUST_BACKTRACE=1
           export CARGO_TERM_COLOR=always
           # Avoid filling disk space
           export RUSTFLAGS="-C strip=symbols"
-          # vendored OpenSSL takes many times to build. Use system one (LibreSSL is supported).
-          export OPENSSL_NO_VENDOR=1 OPENSSL_DIR=/usr
           # Use cargo test since nextest might not support OpenBSD
           if (test -z "\$FAULT"); then
             echo "::group::cargo test (workspace)"