Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve ast-to-dom typing #692

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: improve ast-to-dom typing #692

wants to merge 1 commit into from

Conversation

rpechuk
Copy link
Collaborator

@rpechuk rpechuk commented Feb 16, 2025

Improved the typing of the options parameter of ast-to-dom to be based on InstantiateContext as this is what it is being used for.

@rpechuk rpechuk requested a review from jheer February 16, 2025 21:05
@domoritz domoritz changed the title Imporve ast-to-dom typing feat: improve ast-to-dom typing Feb 17, 2025
jheer
jheer approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@jheer jheer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good! However, if not too much hassle it would be great to also add proper types and comments for the InstantiateContext parameters below.

@rpechuk rpechuk requested a review from jheer February 18, 2025 22:22
jheer
jheer requested changes Feb 18, 2025
View reviewed changes
Copy link
Member

@jheer jheer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for the publish package file that snuck in.

@rpechuk rpechuk force-pushed the ron/ast-to-dom-typing branch from 433009e to 3943eab Compare February 21, 2025 03:34
@rpechuk rpechuk changed the base branch from ron/mosaic-publish to main February 21, 2025 03:35
@rpechuk rpechuk force-pushed the ron/ast-to-dom-typing branch from 3943eab to 529c325 Compare February 21, 2025 03:37
@rpechuk rpechuk requested a review from jheer February 21, 2025 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jheer jheer Awaiting requested review from jheer

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rpechuk @jheer