take screenshots before and after running tests

Author: manolo

scripts/pit/its/hello.js

@@ -37,6 +37,8 @@ const log = s => process.stderr.write(`\x1b[1m=> TEST: \x1b[0;33m${s}\x1b[0m`);
 
   // Go to http://localhost:8080/
   await page.goto(`http://${host}:${port}/`);
+  // Wait for vaadin ready
+  await page.waitForSelector('#outlet > * > *:not(style):not(script)');
 
   await takeScreenshot(page, 'initial-view');
   // Click input[type="text"]

scripts/pit/its/test-utils.js

@@ -46,7 +46,7 @@ let mode, version;
 const args = () => {
   const ret = {
     headless: false,
-    port: '8000',
+    port: '8080',
     host: 'localhost',
     pass: 'Servantes',
     ignoreHTTPSErrors: false,
@@ -80,6 +80,8 @@ const args = () => {
       version = ret.version = a.split('=')[1];
     } else if (/^--prefix=/.test(a)) {
       ret.prefix = a.split('=')[1];
+    } else if (/^--name=/.test(a)) {
+      ret.name = a.split('=')[1];
     }
   });
   if (!ret.url) {

scripts/pit/lib/lib-args.sh

@@ -23,6 +23,7 @@ Use: $0 with the next options:
  --skip-clean      Do not clean maven cache
  --skip-helm       Do not re-install control-center with helm and continue running tests, implies (--offline, --keep-cc)
  --skip-pw         Do not run playwright tests
+ --screenshots     Save screenshots before and after running tests (useful to visit them after theming changes)
  --cluster=name    Run tests in an existing k8s cluster
  --vendor=name     Use a specific cluster vendor to run control-center tests options: [dd, kind, do] (default: kind)
  --keep-cc         Keep control-center running after tests
@@ -83,6 +84,7 @@ checkArgs() {
       --skip-dev) NODEV=true;;
       --skip-prod) NOPROD=true;;
       --skip-pw) SKIPPW=true;;
+      --screenshots) SCREENSHOTS=true;;
       --cluster=*) CLUSTER="$arg";;
       --vendor=*)
         VENDOR="$arg"

scripts/pit/lib/lib-playwright.sh

@@ -1,4 +1,5 @@
 PIT_SCR_FOLDER=`computeAbsolutePath`
+SCRSHT="$PIT_SCR_FOLDER/its/screenshot.js"
 
 ## LIBRARY for installing and running playwright tests
 
@@ -60,3 +61,4 @@ runPlaywrightTests() {
   return $err
 }
 
+

scripts/pit/lib/lib-validate.sh

@@ -111,7 +111,18 @@ runValidations() {
 
   # 11
   if [ -n "$test" -a -z "$SKIPTESTS" -a -z "$SKIPPW" ]; then
-    runPlaywrightTests "$test" "$file" "$mode" "$name" "$version" "--port=$port"  || return 1
+    # Take screenshot before running tests
+    [ -n "$SCREENSHOTS" ] && runPlaywrightTests "$SCRSHT" "$file" "$mode" "$name" "$version" "--port=$port" "--prefix=_before"
+
+    runPlaywrightTests "$test" "$file" "$mode" "$name" "$version" "--port=$port"
+    test_result=$?
+
+    # Take screenshot after tests succeed
+    [ -n "$SCREENSHOTS"  -a $test_result = 0 ] && runPlaywrightTests "$SCRSHT" "$file" "$mode" "$name" "$version" "--port=$port" "--prefix=_after"
+
+
+    # Return the test result
+    [ $test_result != 0 ] && return 1
   elif [ -n "$TEST" ]; then
     cmd "## No PW tests to run"
   fi