migrate scripts/pit/its/hilla-react-cli.js to use test-utils

Author: manolo

scripts/pit/its/hilla-react-cli.js

@@ -1,35 +1,28 @@
-const { chromium } = require('playwright');
-
-let headless = false, host = 'localhost', port = '8080', hub = false;
-process.argv.forEach(a => {
-  if (/^--headless/.test(a)) {
-    headless = true;
-  } else if (/^--ip=/.test(a)) {
-    ip = a.split('=')[1];
-  } else if (/^--port=/.test(a)) {
-    port = a.split('=')[1];
-  }
-});
+const { expect } = require('@playwright/test');
+const { log, args, createPage, closePage, takeScreenshot, waitForServerReady, dismissDevmode } = require('./test-utils');
 
 (async () => {
-  const browser = await chromium.launch({
-    headless: headless,
-    chromiumSandbox: false
-  });
-  const context = await browser.newContext();
+    const arg = args();
+
+    const page = await createPage(arg.headless);
 
-  const page = await context.newPage();
-  page.on('console', msg => console.log("> CONSOLE:", (msg.text() + ' - ' + msg.location().url).replace(/\s+/g, ' ')));
-  page.on('pageerror', err => console.log("> PAGEERROR:", ('' + err).replace(/\s+/g, ' ')));
+    await waitForServerReady(page, arg.url);
 
-  await page.goto(`http://${host}:${port}/`);
+    // Dismiss dev mode notification if present
+    await dismissDevmode(page);
+    await takeScreenshot(page, __filename, 'page-loaded');
 
-  await page.locator('text=Hello').nth(0).click();
-  await page.locator('input[type="text"]').fill('Greet');
-  await page.locator('text=Say hello').click();
-  await page.locator('text=Hello Greet');
+    await page.locator('text=Hello').nth(0).click();
+    await takeScreenshot(page, __filename, 'hello-clicked');
+    
+    await page.locator('input[type="text"]').fill('Greet');
+    await takeScreenshot(page, __filename, 'input-filled');
+    
+    await page.locator('text=Say hello').click();
+    await takeScreenshot(page, __filename, 'say-hello-clicked');
+    
+    await page.locator('text=Hello Greet');
+    await takeScreenshot(page, __filename, 'greeting-displayed');
 
-  // ---------------------
-  await context.close();
-  await browser.close();
+    await closePage(page);
 })();

scripts/pit/lib/lib-start.sh

@@ -46,7 +46,7 @@ generateStarter() {
     ## workaround in current quarkus-maven-plugin 3.28.3 : -Dextensions=rest,vaadin
     ## https://github.com/quarkusio/quarkus/issues/50528
     vaadin-quarkus) cmd="$MVN -ntp -q -B io.quarkus.platform:quarkus-maven-plugin:create -Dextensions=rest,vaadin -DwithCodestart -DprojectGroupId=com.vaadin.starter -DprojectArtifactId=$_name" ;;
-    hilla-*-cli)    cmd="npx @hilla/cli init --react $_name" ;;
+    hilla-*-cli)    cmd="npx -y @hilla/cli init --react $_name" ;;
   esac
   runCmd -f "Generating $1" "$cmd" || return 1
   cmd "cd '$_name'" && cd "$_name" || return 1