-
Notifications
You must be signed in to change notification settings - Fork 0
Default database configuration #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peholmst
commented
Jun 10, 2025
| * directory. This method is a workaround that deduces the project folder correctly and uses a system property to | ||
| * instruct Vaadin to use it. | ||
| */ | ||
| private static void initializeProjectFolder() { |
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mshabarov @Artur- Is this something that could be added to Flow?
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like this: vaadin/flow#21683
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prepares the Walking Skeleton for Control Center in terms of database connectivity:
./mvnw spring-boot:test-runstarts the application using a temporary PostgreSQL database inside a Testcontainer.The above is what you should be doing in real applications. However, they all require Docker. We don't want to require developers to have Docker installed just to start up their working skeletons. To fix this, there is a
h2-local-developmentMaven profile that gets activated by default if no other Maven profile has been activated. This profile uses an in-memory H2 database instead of PostgreSQL. In practice, this means that:./mvnw spring-boot:runstarts the application using H2productionMaven profile)integration-testMaven profile)Once you're ready to ditch H2, you only need to delete a single Maven profile from your pom.xml file.
https://github.com/vaadin/control-center/issues/958 must be fixed for the skeleton to work.
To make everything work with Control Center, this PR also includes the security changes from #66.
This PR should NOT be cherry picked to 24.7.