Skip to content

Commit 4ebd0d4

Browse files
bombsimonbombsimon
committed
Add support for SEMANTIC_VIEW table factor
1 parent 12c0878 commit 4ebd0d4

File tree

7 files changed

+289
-0
lines changed

7 files changed

+289
-0
lines changed

‎src/ast/query.rs

Lines changed: 59 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1410,6 +1410,31 @@ pub enum TableFactor {
14101410
/// The alias for the table.
14111411
alias: Option<TableAlias>,
14121412
},
1413+
/// Snowflake's SEMANTIC_VIEW function for semantic models.
1414+
///
1415+
/// <https://docs.snowflake.com/en/sql-reference/constructs/semantic_view>
1416+
///
1417+
/// ```sql
1418+
/// SELECT * FROM SEMANTIC_VIEW(
1419+
/// tpch_analysis
1420+
/// DIMENSIONS customer.customer_market_segment
1421+
/// METRICS orders.order_average_value
1422+
/// );
1423+
/// ```
1424+
SemanticView {
1425+
/// The name of the semantic model
1426+
name: ObjectName,
1427+
/// List of dimensions or expression referring to dimensions (e.g. DATE_PART('year', col))
1428+
dimensions: Vec<Expr>,
1429+
/// List of metrics (references to objects like orders.value, value, orders.*)
1430+
metrics: Vec<ObjectName>,
1431+
/// List of facts or expressions referring to facts or dimensions.
1432+
facts: Vec<Expr>,
1433+
/// WHERE clause for filtering
1434+
where_clause: Option<Expr>,
1435+
/// The alias for the table
1436+
alias: Option<TableAlias>,
1437+
},
14131438
}
14141439

14151440
/// The table sample modifier options
@@ -2107,6 +2132,40 @@ impl fmt::Display for TableFactor {
21072132
}
21082133
Ok(())
21092134
}
2135+
TableFactor::SemanticView {
2136+
name,
2137+
dimensions,
2138+
metrics,
2139+
facts,
2140+
where_clause,
2141+
alias,
2142+
} => {
2143+
write!(f, "SEMANTIC_VIEW({name}")?;
2144+
2145+
if !dimensions.is_empty() {
2146+
write!(f, " DIMENSIONS {}", display_comma_separated(dimensions))?;
2147+
}
2148+
2149+
if !metrics.is_empty() {
2150+
write!(f, " METRICS {}", display_comma_separated(metrics))?;
2151+
}
2152+
2153+
if !facts.is_empty() {
2154+
write!(f, " FACTS {}", display_comma_separated(facts))?;
2155+
}
2156+
2157+
if let Some(where_clause) = where_clause {
2158+
write!(f, " WHERE {where_clause}")?;
2159+
}
2160+
2161+
write!(f, ")")?;
2162+
2163+
if let Some(alias) = alias {
2164+
write!(f, " AS {alias}")?;
2165+
}
2166+
2167+
Ok(())
2168+
}
21102169
}
21112170
}
21122171
}

‎src/ast/spans.rs

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2032,6 +2032,23 @@ impl Spanned for TableFactor {
20322032
.chain(symbols.iter().map(|i| i.span()))
20332033
.chain(alias.as_ref().map(|i| i.span())),
20342034
),
2035+
TableFactor::SemanticView {
2036+
name,
2037+
dimensions,
2038+
metrics,
2039+
facts,
2040+
where_clause,
2041+
alias,
2042+
} => union_spans(
2043+
name.0
2044+
.iter()
2045+
.map(|i| i.span())
2046+
.chain(dimensions.iter().map(|d| d.span()))
2047+
.chain(metrics.iter().map(|m| m.span()))
2048+
.chain(facts.iter().map(|f| f.span()))
2049+
.chain(where_clause.as_ref().map(|e| e.span()))
2050+
.chain(alias.as_ref().map(|a| a.span())),
2051+
),
20352052
TableFactor::OpenJsonTable { .. } => Span::empty(),
20362053
}
20372054
}

‎src/dialect/mod.rs

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1182,6 +1182,20 @@ pub trait Dialect: Debug + Any {
11821182
fn supports_create_table_like_parenthesized(&self) -> bool {
11831183
false
11841184
}
1185+
1186+
/// Returns true if the dialect supports `SEMANTIC_VIEW()` table functions.
1187+
///
1188+
/// ```sql
1189+
/// SELECT * FROM SEMANTIC_VIEW(
1190+
/// model_name
1191+
/// DIMENSIONS customer.name, customer.region
1192+
/// METRICS orders.revenue, orders.count
1193+
/// WHERE customer.active = true
1194+
/// )
1195+
/// ```
1196+
fn supports_semantic_view(&self) -> bool {
1197+
false
1198+
}
11851199
}
11861200

11871201
/// This represents the operators for which precedence must be defined

‎src/dialect/snowflake.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -564,6 +564,10 @@ impl Dialect for SnowflakeDialect {
564564
fn supports_select_wildcard_exclude(&self) -> bool {
565565
true
566566
}
567+
568+
fn supports_semantic_view(&self) -> bool {
569+
true
570+
}
567571
}
568572

569573
// Peeks ahead to identify tokens that are expected after

‎src/keywords.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -289,6 +289,7 @@ define_keywords!(
289289
DETACH,
290290
DETAIL,
291291
DETERMINISTIC,
292+
DIMENSIONS,
292293
DIRECTORY,
293294
DISABLE,
294295
DISCARD,
@@ -357,6 +358,7 @@ define_keywords!(
357358
EXTERNAL,
358359
EXTERNAL_VOLUME,
359360
EXTRACT,
361+
FACTS,
360362
FAIL,
361363
FAILOVER,
362364
FALSE,
@@ -560,6 +562,7 @@ define_keywords!(
560562
METADATA,
561563
METHOD,
562564
METRIC,
565+
METRICS,
563566
MICROSECOND,
564567
MICROSECONDS,
565568
MILLENIUM,
@@ -817,6 +820,7 @@ define_keywords!(
817820
SECURITY,
818821
SEED,
819822
SELECT,
823+
SEMANTIC_VIEW,
820824
SEMI,
821825
SENSITIVE,
822826
SEPARATOR,

‎src/parser/mod.rs

Lines changed: 65 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13324,6 +13324,7 @@ impl<'a> Parser<'a> {
1332413324
| TableFactor::Pivot { alias, .. }
1332513325
| TableFactor::Unpivot { alias, .. }
1332613326
| TableFactor::MatchRecognize { alias, .. }
13327+
| TableFactor::SemanticView { alias, .. }
1332713328
| TableFactor::NestedJoin { alias, .. } => {
1332813329
// but not `FROM (mytable AS alias1) AS alias2`.
1332913330
if let Some(inner_alias) = alias {
@@ -13438,6 +13439,10 @@ impl<'a> Parser<'a> {
1343813439
} else if self.parse_keyword_with_tokens(Keyword::XMLTABLE, &[Token::LParen]) {
1343913440
self.prev_token();
1344013441
self.parse_xml_table_factor()
13442+
} else if self.dialect.supports_semantic_view()
13443+
&& self.parse_keyword_with_tokens(Keyword::SEMANTIC_VIEW, &[Token::LParen])
13444+
{
13445+
self.parse_semantic_view_table_factor()
1344113446
} else {
1344213447
let name = self.parse_object_name(true)?;
1344313448

@@ -13769,6 +13774,66 @@ impl<'a> Parser<'a> {
1376913774
Ok(XmlPassingClause { arguments })
1377013775
}
1377113776

13777+
fn parse_semantic_view_table_factor(&mut self) -> Result<TableFactor, ParserError> {
13778+
let name = self.parse_object_name(true)?;
13779+
13780+
// Parse DIMENSIONS, METRICS, FACTS and WHERE clauses in flexible order
13781+
let mut dimensions = Vec::new();
13782+
let mut metrics = Vec::new();
13783+
let mut facts = Vec::new();
13784+
let mut where_clause = None;
13785+
13786+
while self.peek_token().token != Token::RParen {
13787+
if self.parse_keyword(Keyword::DIMENSIONS) {
13788+
if !dimensions.is_empty() {
13789+
return Err(ParserError::ParserError(
13790+
"DIMENSIONS clause can only be specified once".to_string(),
13791+
));
13792+
}
13793+
dimensions = self.parse_comma_separated(Parser::parse_expr)?;
13794+
} else if self.parse_keyword(Keyword::METRICS) {
13795+
if !metrics.is_empty() {
13796+
return Err(ParserError::ParserError(
13797+
"METRICS clause can only be specified once".to_string(),
13798+
));
13799+
}
13800+
metrics = self.parse_comma_separated(|parser| parser.parse_object_name(true))?;
13801+
} else if self.parse_keyword(Keyword::FACTS) {
13802+
if !facts.is_empty() {
13803+
return Err(ParserError::ParserError(
13804+
"FACTS clause can only be specified once".to_string(),
13805+
));
13806+
}
13807+
facts = self.parse_comma_separated(Parser::parse_expr)?;
13808+
} else if self.parse_keyword(Keyword::WHERE) {
13809+
if where_clause.is_some() {
13810+
return Err(ParserError::ParserError(
13811+
"WHERE clause can only be specified once".to_string(),
13812+
));
13813+
}
13814+
where_clause = Some(self.parse_expr()?);
13815+
} else {
13816+
return parser_err!(
13817+
"Expected one of DIMENSIONS, METRICS, FACTS or WHERE",
13818+
self.peek_token().span.start
13819+
)?;
13820+
}
13821+
}
13822+
13823+
self.expect_token(&Token::RParen)?;
13824+
13825+
let alias = self.maybe_parse_table_alias()?;
13826+
13827+
Ok(TableFactor::SemanticView {
13828+
name,
13829+
dimensions,
13830+
metrics,
13831+
facts,
13832+
where_clause,
13833+
alias,
13834+
})
13835+
}
13836+
1377213837
fn parse_match_recognize(&mut self, table: TableFactor) -> Result<TableFactor, ParserError> {
1377313838
self.expect_token(&Token::LParen)?;
1377413839

‎tests/sqlparser_snowflake.rs

Lines changed: 126 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4581,3 +4581,129 @@ fn test_drop_constraints() {
45814581
snowflake().verified_stmt("ALTER TABLE tbl DROP FOREIGN KEY k1 RESTRICT");
45824582
snowflake().verified_stmt("ALTER TABLE tbl DROP CONSTRAINT c1 CASCADE");
45834583
}
4584+
4585+
#[test]
4586+
fn test_semantic_view_all_variants_should_pass() {
4587+
let test_cases = [
4588+
("SELECT * FROM SEMANTIC_VIEW(model)", None),
4589+
(
4590+
"SELECT * FROM SEMANTIC_VIEW(model DIMENSIONS dim1, dim2)",
4591+
None,
4592+
),
4593+
(
4594+
"SELECT * FROM SEMANTIC_VIEW(model METRICS met1, met2)",
4595+
None,
4596+
),
4597+
(
4598+
"SELECT * FROM SEMANTIC_VIEW(model FACTS fact1, fact2)",
4599+
None,
4600+
),
4601+
(
4602+
"SELECT * FROM SEMANTIC_VIEW(model DIMENSIONS dim1 METRICS met1)",
4603+
None,
4604+
),
4605+
(
4606+
"SELECT * FROM SEMANTIC_VIEW(model DIMENSIONS dim1 WHERE x > 0)",
4607+
None,
4608+
),
4609+
(
4610+
"SELECT * FROM SEMANTIC_VIEW(model DIMENSIONS dim1) AS sv",
4611+
None,
4612+
),
4613+
(
4614+
"SELECT * FROM SEMANTIC_VIEW(model DIMENSIONS DATE_PART('year', col))",
4615+
None,
4616+
),
4617+
(
4618+
"SELECT * FROM SEMANTIC_VIEW(model METRICS orders.col, orders.col2)",
4619+
None,
4620+
),
4621+
// We can parse in any order bu will always produce a result in a fixed order.
4622+
(
4623+
"SELECT * FROM SEMANTIC_VIEW(model WHERE x > 0 DIMENSIONS dim1)",
4624+
Some("SELECT * FROM SEMANTIC_VIEW(model DIMENSIONS dim1 WHERE x > 0)"),
4625+
),
4626+
(
4627+
"SELECT * FROM SEMANTIC_VIEW(model METRICS met1 DIMENSIONS dim1)",
4628+
Some("SELECT * FROM SEMANTIC_VIEW(model DIMENSIONS dim1 METRICS met1)"),
4629+
),
4630+
(
4631+
"SELECT * FROM SEMANTIC_VIEW(model FACTS fact1 DIMENSIONS dim1)",
4632+
Some("SELECT * FROM SEMANTIC_VIEW(model DIMENSIONS dim1 FACTS fact1)"),
4633+
),
4634+
];
4635+
4636+
for (input_sql, expected_sql) in test_cases {
4637+
if let Some(expected) = expected_sql {
4638+
// Test that non-canonical order gets normalized
4639+
let parsed = snowflake().parse_sql_statements(input_sql).unwrap();
4640+
let formatted = parsed[0].to_string();
4641+
assert_eq!(formatted, expected);
4642+
} else {
4643+
snowflake().verified_stmt(input_sql);
4644+
}
4645+
}
4646+
}
4647+
4648+
#[test]
4649+
fn test_semantic_view_invalid_queries_should_fail() {
4650+
let invalid_sqls = [
4651+
"SELECT * FROM SEMANTIC_VIEW(model DIMENSIONS dim1 INVALID inv1)",
4652+
"SELECT * FROM SEMANTIC_VIEW(model DIMENSIONS dim1 DIMENSIONS dim2)",
4653+
"SELECT * FROM SEMANTIC_VIEW(model METRICS SUM(met1.avg))",
4654+
];
4655+
4656+
for sql in invalid_sqls {
4657+
let result = snowflake().parse_sql_statements(sql);
4658+
assert!(result.is_err(), "Expected error for invalid SQL: {}", sql);
4659+
}
4660+
}
4661+
4662+
#[test]
4663+
fn test_semantic_view_ast_structure() {
4664+
let sql = r#"SELECT * FROM SEMANTIC_VIEW(
4665+
my_model
4666+
DIMENSIONS DATE_PART('year', date_col), region_name
4667+
METRICS orders.revenue, orders.count
4668+
WHERE active = true
4669+
) AS model_alias"#;
4670+
4671+
let stmt = snowflake().parse_sql_statements(sql).unwrap();
4672+
match &stmt[0] {
4673+
Statement::Query(q) => {
4674+
if let SetExpr::Select(select) = q.body.as_ref() {
4675+
if let Some(TableWithJoins { relation, .. }) = select.from.first() {
4676+
match relation {
4677+
TableFactor::SemanticView {
4678+
name,
4679+
dimensions,
4680+
metrics,
4681+
facts,
4682+
where_clause,
4683+
alias,
4684+
} => {
4685+
assert_eq!(name.to_string(), "my_model");
4686+
assert_eq!(dimensions.len(), 2);
4687+
assert_eq!(dimensions[0].to_string(), "DATE_PART('year', date_col)");
4688+
assert_eq!(dimensions[1].to_string(), "region_name");
4689+
assert_eq!(metrics.len(), 2);
4690+
assert_eq!(metrics[0].to_string(), "orders.revenue");
4691+
assert_eq!(metrics[1].to_string(), "orders.count");
4692+
assert!(facts.is_empty());
4693+
assert!(where_clause.is_some());
4694+
assert_eq!(where_clause.as_ref().unwrap().to_string(), "active = true");
4695+
assert!(alias.is_some());
4696+
assert_eq!(alias.as_ref().unwrap().name.value, "model_alias");
4697+
}
4698+
_ => panic!("Expected SemanticView table factor"),
4699+
}
4700+
} else {
4701+
panic!("Expected table in FROM clause");
4702+
}
4703+
} else {
4704+
panic!("Expected SELECT statement");
4705+
}
4706+
}
4707+
_ => panic!("Expected Query statement"),
4708+
}
4709+
}

0 commit comments

Comments
 (0)