fix: remove CLIENT REPLY, CLIENT UNBLOCK, and QUIT

These three commands are incompatible with (or deprecated for) GLIDE's
architecture and no other GLIDE client exposes them:

- CLIENT REPLY toggles reply-mode state that glide-core does not track,
  and on the multiplexed connection it desynchronizes request/response
  matching for every caller sharing the connection.
- CLIENT UNBLOCK acts on another client by ID, but GLIDE manages blocking
  commands internally and does not expose the connection IDs needed to
  use it, so there is no supported use case.
- QUIT is deprecated server-side; GLIDE owns the connection lifecycle, and
  closing the shared multiplexed connection is harmful. Users should close
  the client object instead.

Remove the methods and their lint tests entirely so they cannot be used.

Fixes #183

Signed-off-by: Alex Le <alex.le@improving.com>

Author: Aryex

lib/valkey/commands/connection_commands.rb

@@ -47,25 +47,6 @@ def select(db)
         send_command(RequestType::SELECT, [db])
       end
 
-      # Close the connection.
-      #
-      # @deprecated The QUIT command is deprecated since Redis 7.2.0 / Valkey 7.2+.
-      #   Clients should use the `close` method directly instead.
-      #   This avoids lingering TIME_WAIT sockets on the server side.
-      #
-      # @return [String] `OK` or nil if connection already closed
-      # @see https://redis.io/docs/latest/commands/quit/
-      def quit
-        # For compatibility, we still support QUIT but recommend using close() instead
-        send_command(RequestType::QUIT)
-      rescue ConnectionError
-        # Server closes connection immediately after QUIT
-        nil
-      ensure
-        # Clean up our side of the connection
-        close if respond_to?(:close)
-      end
-
       # Switch to a different protocol version and handshake with the server.
       #
       # @param [Integer] protover Protocol version (2 or 3)
@@ -219,25 +200,6 @@ def client_unpause(route: nil)
         send_command(RequestType::CLIENT_UNPAUSE, [], route: route)
       end
 
-      # Configure client reply mode.
-      #
-      # @param [String] mode Reply mode (ON, OFF, SKIP)
-      # @return [String] `OK`
-      def client_reply(mode)
-        send_command(RequestType::CLIENT_REPLY, [mode])
-      end
-
-      # Unblock a client blocked in a blocking operation.
-      #
-      # @param [Integer] client_id ID of the client to unblock
-      # @param [String] unblock_type Optional unblock type (TIMEOUT, ERROR)
-      # @return [Integer] 1 if client was unblocked, 0 otherwise
-      def client_unblock(client_id, unblock_type = nil)
-        args = [client_id]
-        args << unblock_type if unblock_type
-        send_command(RequestType::CLIENT_UNBLOCK, args)
-      end
-
       # Set client connection information.
       #
       # @param [String] attr Attribute to set (lib-name, lib-ver)

test/lint/connection_commands.rb

@@ -108,11 +108,6 @@ def test_client_pause_unpause
       assert_equal "OK", r.client(:unpause)
     end
 
-    def test_client_reply
-      # Use the server commands interface that's known to work
-      assert_equal "OK", r.client(:reply, "ON")
-    end
-
     def test_client_set_info
       target_version "7.2" do
         # Use the server commands interface that's known to work
@@ -123,13 +118,6 @@ def test_client_set_info
       end
     end
 
-    def test_client_unblock
-      # Use the server commands interface that's known to work
-      client_id = r.client(:id)
-      result = r.client(:unblock, client_id)
-      assert [0, 1].include?(result), "Unblock should return 0 or 1"
-    end
-
     def test_client_no_evict
       # Use the server commands interface that's known to work
       assert_equal "OK", r.client_no_evict(:on)
@@ -195,11 +183,5 @@ def test_reset
       end
       assert_nil r.client_get_name
     end
-
-    def test_quit
-      # NOTE: This test is tricky because QUIT closes the connection
-      # We'll skip it in lint tests to avoid connection issues
-      skip("QUIT command closes connection - tested separately")
-    end
   end
 end

test/lint/server_commands.rb

@@ -156,15 +156,6 @@ def test_client_set_info
       end
     end
 
-    def test_client_unblock
-      result = r.client(:unblock, r.client(:id))
-      assert [0, 1].include?(result), "Expected unblock to return 0 or 1"
-    end
-
-    def test_client_reply
-      assert_equal "OK", r.client(:reply, "ON") # TODO: "OFF" or "SKIP" doesnt work yet
-    end
-
     def test_client_kill
       # CLIENT KILL by address doesn't work reliably in cluster mode because
       # the command may be routed to a different node than where the client is connected