Fix CLUSTER SLOTS crashes when used with fake-client. #2915
+91
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Su Ko <[email protected]>
|
|
||
| for (int i = 0; i < 100; i++) { | ||
| ValkeyModuleCallReply *rep = ValkeyModule_Call(detached_ctx, "CLUSTER", "c", "SLOTS"); | ||
| ValkeyModule_Log(detached_ctx, "notice", "Worker reply %d", i); |
Member
There was a problem hiding this comment.
Maybe we could take a peek at the data which is returned, just enough to know it's correct?
Signed-off-by: Su Ko <[email protected]>
Member
|
@zuiderkwast This PR was separated tested and was found to solve the problem. So thanks!! It would be tremendously helpful if this could get into the 9.0.1 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix CLUSTER SLOTS crashes when used with fake-client. #2912
I suspect this is due to a race condition occurring when two Fake Clients are freed. Therefore, I implemented a fix to skip the cache lookup when a Fake Client is used.
Thanks