Skip to content

Consider dropping local usage of {{ .Release.Name }} in mounts, container names, etc. #28

@sirn

Description

@sirn

This is a relic of the past, and makes adding an additional sidecar containers harder than it should be, as everything now requires templating if it needs to reference to existing volumes (e.g. VSM):

extraVolumeMounts: |
  - name: {{ .Release.Name }}-vsm
    # ...

As doing {{ .Release.Name }} here and elsewhere in a Pod (e.g. container name) doesn't have any real gains, we should consider dropping it.

Since we want to avoid breaking existing deploy, a possible migration strategy might be to add server.nameFromReleaseName with the default set to true for the time being, which retains current behavior with a deprecation message, then switch to false sometimes in the future, and eventually drop the server.nameFromReleaseName/{{ .Release.Name }} usage altogether.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions