Skip to content

Commit fd5be99

Browse files
committed
Keep the builder's home out of the scene
meta.root was the absolute path of whoever ran the command. Nothing read it: not the viewer, not the ordering. It only waited to be pasted into a bug report.
1 parent 80c5cfd commit fd5be99

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

‎bin/gitdiff3d.js‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,10 @@ async function main() {
7575
const lines = context === null ? flags.context : context;
7676
if (!built.has(lines)) {
7777
const diff = parseDiff(diffText(revisions, root, lines));
78+
// The scene travels: it is served, printed and pasted, so it carries no
79+
// path from the machine that built it.
7880
built.set(lines, orderHunks(
79-
buildScene(diff, { root, label, context: lines }, readSource, flags.maxHunks),
81+
buildScene(diff, { label, context: lines }, readSource, flags.maxHunks),
8082
flags.order,
8183
));
8284
}

0 commit comments

Comments
 (0)