chore(internal events): Enable pedantic Clippy lints (#26613)

Author: pront

src/internal_events/adaptive_concurrency.rs

@@ -25,6 +25,11 @@ registered_event! {
     }
 
     fn emit(&self, data: AdaptiveConcurrencyLimitData) {
+        // https://github.com/vectordotdev/vector/issues/23659
+        #[allow(
+            clippy::cast_precision_loss,
+            reason = "Metrics use f64"
+        )]
         self.limit.record(data.concurrency as f64);
         let reached_limit = if data.reached_limit { 1.0 } else { Default::default() };
         self.reached_limit.record(reached_limit);
@@ -41,6 +46,11 @@ registered_event! {
     }
 
     fn emit(&self, in_flight: u64) {
+        // https://github.com/vectordotdev/vector/issues/23659
+        #[allow(
+            clippy::cast_precision_loss,
+            reason = "Metrics use f64"
+        )]
         self.in_flight.record(in_flight as f64);
     }
 }

src/internal_events/aggregate.rs

@@ -74,6 +74,8 @@ mod tests {
     }
 
     #[test]
+    // https://github.com/vectordotdev/vector/issues/23659
+    #[allow(clippy::float_cmp, reason = "Counters are exact integers")]
     fn emits_total_and_legacy_counters() {
         let metrics = capture_metrics(|| AggregateUpdateFailed.emit());
 

src/internal_events/aws_sqs.rs

@@ -20,7 +20,7 @@ mod s3 {
     use vector_lib::histogram;
     use vector_lib::internal_event::HistogramName;
 
-    use super::*;
+    use super::{CounterName, InternalEvent, NamedInternalEvent, counter, error_stage, error_type};
     use crate::sources::aws_s3::sqs::ProcessingError;
 
     #[derive(Debug, NamedInternalEvent)]

src/internal_events/doris.rs

@@ -11,6 +11,8 @@ pub struct DorisRowsLoaded {
 }
 
 impl InternalEvent for DorisRowsLoaded {
+    // https://github.com/vectordotdev/vector/issues/23659
+    #[allow(clippy::cast_sign_loss, reason = "Input bounds audit deferred")]
     fn emit(self) {
         trace!(
             message = "Doris rows loaded successfully.",
@@ -33,6 +35,8 @@ pub struct DorisRowsFiltered {
 }
 
 impl InternalEvent for DorisRowsFiltered {
+    // https://github.com/vectordotdev/vector/issues/23659
+    #[allow(clippy::cast_sign_loss, reason = "Input bounds audit deferred")]
     fn emit(self) {
         warn!(
             message = "Doris rows filtered during loading.",

src/internal_events/exec.rs

@@ -148,34 +148,30 @@ pub enum ExecFailedToSignalChild {
 
 impl ExecFailedToSignalChild {
     fn to_error_code(&self) -> String {
-        use ExecFailedToSignalChild::*;
-
         match self {
             #[cfg(unix)]
-            SignalError(err) => format!("errno_{err}"),
+            Self::SignalError(err) => format!("errno_{err}"),
             #[cfg(unix)]
-            FailedToMarshalPid(_) => String::from("failed_to_marshal_pid"),
+            Self::FailedToMarshalPid(_) => String::from("failed_to_marshal_pid"),
             #[cfg(unix)]
-            NoPid => String::from("no_pid"),
+            Self::NoPid => String::from("no_pid"),
             #[cfg(windows)]
-            IoError(err) => err.to_string(),
+            Self::IoError(err) => err.to_string(),
         }
     }
 }
 
 impl std::fmt::Display for ExecFailedToSignalChild {
     fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
-        use ExecFailedToSignalChild::*;
-
         match self {
             #[cfg(unix)]
-            SignalError(err) => write!(f, "errno: {err}"),
+            Self::SignalError(err) => write!(f, "errno: {err}"),
             #[cfg(unix)]
-            FailedToMarshalPid(err) => write!(f, "failed to marshal pid to i32: {err}"),
+            Self::FailedToMarshalPid(err) => write!(f, "failed to marshal pid to i32: {err}"),
             #[cfg(unix)]
-            NoPid => write!(f, "child had no pid"),
+            Self::NoPid => write!(f, "child had no pid"),
             #[cfg(windows)]
-            IoError(err) => write!(f, "io error: {err}"),
+            Self::IoError(err) => write!(f, "io error: {err}"),
         }
     }
 }

src/internal_events/file.rs

@@ -36,6 +36,8 @@ pub struct FileOpen {
 }
 
 impl InternalEvent for FileOpen {
+    // https://github.com/vectordotdev/vector/issues/23659
+    #[allow(clippy::cast_precision_loss, reason = "Metrics use f64")]
     fn emit(self) {
         gauge!(GaugeName::OpenFiles).set(self.count as f64);
     }
@@ -502,6 +504,11 @@ mod source {
     }
 
     impl InternalEvent for FileCheckpointed {
+        // https://github.com/vectordotdev/vector/issues/23659
+        #[allow(
+            clippy::cast_possible_truncation,
+            reason = "Bounds and overflow audit deferred"
+        )]
         fn emit(self) {
             debug!(
                 message = "Files checkpointed.",

src/internal_events/heartbeat.rs

@@ -13,6 +13,8 @@ pub struct Heartbeat {
 }
 
 impl InternalEvent for Heartbeat {
+    // https://github.com/vectordotdev/vector/issues/23659
+    #[allow(clippy::cast_precision_loss, reason = "Metrics use f64")]
     fn emit(self) {
         trace!(target: "vector", message = "Beep.");
         gauge!(GaugeName::UptimeSeconds).set(self.since.elapsed().as_secs() as f64);

src/internal_events/http.rs

@@ -69,6 +69,8 @@ pub struct HttpEventsReceived<'a> {
 }
 
 impl InternalEvent for HttpEventsReceived<'_> {
+    // https://github.com/vectordotdev/vector/issues/23659
+    #[allow(clippy::cast_precision_loss, reason = "Metrics use f64")]
     fn emit(self) {
         trace!(
             message = "Events received.",
@@ -104,6 +106,7 @@ pub struct HttpBadRequest<'a> {
 
 #[cfg(feature = "sources-utils-http")]
 impl<'a> HttpBadRequest<'a> {
+    #[must_use]
     pub fn new(code: u16, message: &'a str) -> Self {
         Self {
             code,

src/internal_events/http_client.rs

@@ -296,7 +296,7 @@ fn remove_sensitive(
         HeaderName::from_static("x-api-key"),
         HeaderName::from_static("api-key"),
     ];
-    for (name, value) in headers.iter_mut() {
+    for (name, value) in &mut headers {
         if sensitive.contains(name) || extra.contains(name) {
             value.set_sensitive(true);
         }

src/internal_events/kafka.rs

@@ -151,6 +151,9 @@ pub struct KafkaStatisticsReceived<'a> {
 }
 
 impl InternalEvent for KafkaStatisticsReceived<'_> {
+    // https://github.com/vectordotdev/vector/issues/23659
+    #[allow(clippy::cast_precision_loss, reason = "Metrics use f64")]
+    #[allow(clippy::cast_sign_loss, reason = "Input bounds audit deferred")]
     fn emit(self) {
         gauge!(GaugeName::KafkaQueueMessages).set(self.statistics.msg_cnt as f64);
         gauge!(GaugeName::KafkaQueueMessagesBytes).set(self.statistics.msg_size as f64);