refactor(value): Preserve known UTF-8 as strings by bruceg · Pull Request #26608 · vectordotdev/vector

bruceg · 2026-10-08T23:02:10Z

Summary

Keeps statically known UTF-8 values in Value::String. Updates source metadata, formatted values, and affected test expectations.

References

Vector configuration

How did you test this PR?

Does this PR include user facing changes?

Yes. Please add a changelog fragment based on our guidelines.
No. A maintainer will apply the no-changelog label to this PR.

Contributor Guidelines

Please read our Vector contributor resources.
Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
Before pushing, follow our pre-push guidance.
After a review is requested, please avoid force pushes to help us review incrementally.
- Feel free to push as many commits as you want. They will be squashed into one before merging.
- For example, you can run git merge origin master and git push.

chatgpt-codex-connector · 2026-10-08T23:02:19Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-09T21:27:38.232540Z	`613cdd2`	New commits

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

datadoghq-integration

Fluent string conversion adds literal quotes and escapes to log contents. This changes payload data rather than only its internal representation.

_{Open Bits AI session}

_{🤖 Bits Code Review · Commit 626c987 · @DataDog review to ask questions}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 626c987b44

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Keeps statically known UTF-8 values in Value::String. Updates source metadata, formatted values, and affected test expectations.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0a6b440d90

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

gwenaskell

nice! just one suggestion below

When truncating the `message` field of a log event, the `datadog_logs` converts it into a string, chops part of it off, adds a truncation marker string, but then stuffs it back into the event as a `Bytes` value. Since we know it is valid UTF-8 by construction, we can use the `String` type instead. This was previously submitted as part of #26608. While it looks like a bug fix, the extra boundary check is not actually reachable in the current caller and so is purely defensive against future (mis)uses.

bruceg requested a review from a team as a code owner October 8, 2026 23:02

bruceg added type: tech debt A code change that does not add user value. domain: core Anything related to core crates i.e. vector-core, core-common, etc no-changelog Changes in this PR do not need user-facing explanations in the release changelog labels Oct 8, 2026

github-actions Bot added domain: sources Anything related to the Vector's sources domain: sinks Anything related to the Vector's sinks labels Oct 8, 2026

bruceg requested a review from gwenaskell October 8, 2026 23:02

datadoghq-integration Bot reviewed Oct 8, 2026

View reviewed changes

Comment thread src/sources/fluent/message.rs Outdated

chatgpt-codex-connector Bot reviewed Oct 8, 2026

View reviewed changes

Comment thread src/sources/fluent/message.rs Outdated

Comment thread src/conditions/datadog_search.rs Outdated

Comment thread src/sources/fluent/message.rs Outdated

Comment thread src/sources/fluent/message.rs

Comment thread src/sources/aws_kinesis_firehose/handlers.rs

refactor(value): Preserve known UTF-8 as strings

0a6b440

Keeps statically known UTF-8 values in Value::String. Updates source metadata, formatted values, and affected test expectations.

bruceg force-pushed the bruceg/value-string-conversion-1 branch from 626c987 to 0a6b440 Compare October 8, 2026 23:46

chatgpt-codex-connector Bot reviewed Oct 8, 2026

View reviewed changes

Comment thread lib/vector-core/src/config/mod.rs

gwenaskell approved these changes Oct 9, 2026

View reviewed changes

Comment thread src/sources/fluent/message.rs Outdated

thomasqueirozb reviewed Oct 9, 2026

View reviewed changes

Comment thread src/sources/windows_event_log/integration_tests.rs

Comment thread src/sinks/datadog/logs/sink.rs Outdated

bruceg added 3 commits October 9, 2026 15:13

Rewrite more Bytes::from_static cases with string values

643b4be

fix rmpv::Value::String into Value

249e4d7

Reverted bug fix to datadog_logs sink

613cdd2

bruceg requested a review from thomasqueirozb October 9, 2026 21:24

thomasqueirozb approved these changes Oct 9, 2026

View reviewed changes

bruceg added this pull request to the merge queue Oct 9, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 9, 2026

thomasqueirozb added this pull request to the merge queue Oct 9, 2026

Merged via the queue into master with commit 88da8cb Oct 9, 2026
132 checks passed

thomasqueirozb deleted the bruceg/value-string-conversion-1 branch October 9, 2026 22:50

github-actions Bot locked and limited conversation to collaborators Oct 9, 2026

Navigation Menu

Repository navigation

refactor(value): Preserve known UTF-8 as strings - #26608

refactor(value): Preserve known UTF-8 as strings#26608
thomasqueirozb merged 4 commits into
masterfrom
bruceg/value-string-conversion-1

bruceg commented Oct 8, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 8, 2026 •

edited

Loading

Uh oh!

datadoghq-integration Bot left a comment

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

gwenaskell left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

bruceg commented Oct 8, 2026

Summary

References

Vector configuration

How did you test this PR?

Does this PR include user facing changes?

Contributor Guidelines

Uh oh!

chatgpt-codex-connector Bot commented Oct 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

datadoghq-integration Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

gwenaskell left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chatgpt-codex-connector Bot commented Oct 8, 2026 •

edited

Loading