-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fix(anthropic): read input_tokens from message_delta as fallback #10671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wong2
wants to merge
1
commit into
vercel:main
Choose a base branch
from
wong2:anthropic-input-tokens
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The condition
if (!usage.inputTokens)uses truthiness check which incorrectly treats a valid value of0tokens as "not set", causing it to overwrite correct values frommessage_startwith fallback values frommessage_delta.View Details
Analysis
Falsy check on
usage.inputTokenscauses overwriting valid zero valueWhat fails: In
anthropic-messages-language-model.ts:1488, the conditionif (!usage.inputTokens)uses a truthiness check that incorrectly treatsinput_tokens: 0(a valid Anthropic API value) as "not set", causing it to overwrite the correct zero value with a fallback value frommessage_delta.How to reproduce:
message_startevent containingusage.input_tokens: 0(e.g., when using cache hits or other edge cases)message_startevent and setsusage.inputTokens = 0message_deltaarrives withusage: { output_tokens: X, input_tokens: Y, ... }, the falsy check on line 1488 evaluates totrue(since0 && trueis falsy in JavaScript)usage.inputTokens = value.usage.input_tokens ?? 0, overwriting the correct0with themessage_deltavalueResult: The final reported
inputTokensis incorrect - it uses the value frommessage_deltainstead of the value frommessage_startExpected: According to Anthropic API documentation,
input_tokenshas a minimum value of 0, meaning zero is a valid and legitimate value. The fallback should only trigger wheninputTokenshasn't been set (isundefined), not when it's legitimately set to0.Fix: Change the condition from
if (!usage.inputTokens)toif (usage.inputTokens === undefined)to explicitly check for undefined rather than relying on truthiness. This properly distinguishes between "not set" (undefined) and "set to zero" (0).