Skip to content

Commit ec9cc14

Browse files
committed
Clear up flag documentation and strange logic
Signed-off-by: Dusty DeWeese <[email protected]>
1 parent 22ef443 commit ec9cc14

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

vpr/src/base/read_options.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1986,9 +1986,10 @@ argparse::ArgumentParser create_arg_parser(std::string prog_name, t_options& arg
19861986

19871987
route_timing_grp.add_argument<float>(args.router_high_fanout_max_slope, "--router_high_fanout_max_slope")
19881988
.help(
1989-
"Maximum routing predictor slope where high fanout routing is enabled.\n"
1990-
" -1.0 is normal progress, 0 is no progress.")
1991-
.default_value("-0.5")
1989+
"Minimum routing progress where high fanout routing is enabled."
1990+
" This is a ratio of the actual congestion reduction to what is expected based in the history.\n"
1991+
" 1.0 is normal progress, 0 is no progress.")
1992+
.default_value("0.1")
19921993
.show_in(argparse::ShowIn::HELP_ONLY);
19931994

19941995
route_timing_grp.add_argument<e_router_lookahead, ParseRouterLookahead>(args.router_lookahead_type, "--router_lookahead")

vpr/src/route/route_timing.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1223,7 +1223,7 @@ static bool timing_driven_route_sink(
12231223
//We normally route high fanout nets by only adding spatially close-by routing to the heap (reduces run-time).
12241224
//However, if the current sink is 'critical' from a timing perspective, we put the entire route tree back onto
12251225
//the heap to ensure it has more flexibility to find the best path.
1226-
if (high_fanout && !sink_critical && !net_is_global && !net_is_clock && !(routing_predictor.get_slope() > router_opts.high_fanout_max_slope)) {
1226+
if (high_fanout && !sink_critical && !net_is_global && !net_is_clock && -routing_predictor.get_slope() > router_opts.high_fanout_max_slope) {
12271227
std::tie(found_path, cheapest) = router.timing_driven_route_connection_from_route_tree_high_fanout(rt_root,
12281228
sink_node,
12291229
cost_params,

0 commit comments

Comments
 (0)