Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor extraction functions to resolve confusion around adding/returning extracted AST #2

Open
anderslanglands opened this issue Sep 17, 2022 · 0 comments
Assignees

Comments

@anderslanglands
Copy link
Contributor

Currently some of the extraction functions return an AST object, eg ClassDecl, while others insert what they’re extracting directly into the AST. To make it more confusing, some functions update already_visited themselves, while others expect the caller to do it.

We need to figure out if we can make them all work the same way and do so.

@anderslanglands anderslanglands self-assigned this Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant