sigh double restart

viamrobotics · Jan 12, 2025 · f68e150 · f68e150
1 parent cdf3fc8
commit f68e150
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/subsystems/viamagent/viamagent.go b/subsystems/viamagent/viamagent.go
@@ -72,7 +72,7 @@ func (a *agentSubsystem) Update(ctx context.Context, cfg *pb.DeviceSubsystemConf
 
 	expectedPath := filepath.Join(agent.ViamDirs["bin"], subsysName)
 	if runtime.GOOS == "windows" {
-		// no systemd on windows -- check if binary is runnable, then restart service.
+		// no systemd on windows -- for now you need to double-restart.
 		if _, err := exec.Command(expectedPath, "--version").Output(); err != nil {
 			return false, errw.Wrap(err, "testing binary")
 		}
@@ -81,10 +81,10 @@ func (a *agentSubsystem) Update(ctx context.Context, cfg *pb.DeviceSubsystemConf
 		// if _, err := exec.Command("powershell", "-command", "Restart-Service viam-agent").Output(); err != nil {
 		// 	return false, errw.Wrap(err, "restarting windows service")
 		// }
-		if agent.GlobalCancel == nil {
-			return false, errors.New("can't call globalCancel because it's nil")
-		}
-		agent.GlobalCancel()
+		// if agent.GlobalCancel == nil {
+		// 	return false, errors.New("can't call globalCancel because it's nil")
+		// }
+		// agent.GlobalCancel()
 		return true, nil
 	}