Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the API more well definied with Interfaces #34

Closed
jasinner opened this issue Oct 7, 2016 · 2 comments
Closed

Make the API more well definied with Interfaces #34

jasinner opened this issue Oct 7, 2016 · 2 comments

Comments

@jasinner
Copy link
Member

jasinner commented Oct 7, 2016

While it probably works when you know what to call when, the thing that it's not marked as API, rather blended into different classes and packages mixed with implementation, may lead someone to think that the API is subject to change without prior notice.

It would be ideal if there were some interfaces which would contain only the methods supposed to be called by the integrating application.

@gcmurphy
Copy link
Contributor

gcmurphy commented Oct 7, 2016

Did you mean to create this against https://github.com/victims/victims-lib-java? This project was always intended to be a command line wrapper for victims-lib. It isn't intended to be used as an API.

@jasinner
Copy link
Member Author

jasinner commented Oct 9, 2016

Whoops, yes, I meant to create it in victims-lib-java. Done now:
victims/victims-lib-java#48

@jasinner jasinner closed this as completed Oct 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants