Skip to content

Commit a1769d7

Browse files
lambdalisueclaude
andcommitted
fix: address PR review comments for documentation accuracy
- Remove reference to non-existent :FallCustomCheck command - Fix coordinator list (compact, separate instead of stack) - Fix theme list (ASCII, DOUBLE, SINGLE instead of MINIMAL) - Remove "delete" from FallSession description - Clarify that mappings can be confirmed (not customized) via F1 - Update examples to match actual available components 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
1 parent ada1dca commit a1769d7

File tree

1 file changed

+12
-13
lines changed

1 file changed

+12
-13
lines changed

doc/fall.txt

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ Users can define additional sources in "custom.ts" to suit their needs. See
104104
|fall-customization| for customization details.
105105

106106
Within the picker window, the following default mappings are applied. These
107-
can be confirmed or customized via the <F1> help prompt.
107+
can be confirmed via the <F1> help prompt.
108108

109109
Navigation~
110110
Key Description~
@@ -155,7 +155,7 @@ Session Management~
155155
Fall provides session management commands to save and resume picker states:
156156

157157
*:FallSession*
158-
:FallSession Open the session manager to view, resume, or delete saved
158+
:FallSession Open the session manager to view and resume saved
159159
sessions. Sessions preserve the picker state including
160160
query, selections, and cursor position.
161161

@@ -816,7 +816,8 @@ Coordinator~
816816

817817
Built-in coordinators:
818818
- modern: Floating windows with customizable dimensions
819-
- stack: Stacked layout for smaller screens
819+
- compact: Compact layout with minimal spacing
820+
- separate: Separate windows for each component
820821

821822
*fall-module-theme*
822823
Theme~
@@ -825,7 +826,9 @@ Theme~
825826

826827
Built-in themes:
827828
- MODERN_THEME: Clean, modern appearance with rounded borders
828-
- MINIMAL_THEME: Simplified appearance without decorations
829+
- ASCII_THEME: ASCII art style borders
830+
- DOUBLE_THEME: Double-line borders
831+
- SINGLE_THEME: Single-line borders
829832

830833
*fall-module-source*
831834
Source~
@@ -842,7 +845,7 @@ Matcher~
842845
can be incremental (reusing previous results) or non-incremental.
843846

844847
Interface: (items, query) -> AsyncIterableIterator<MatchedItem>
845-
Examples: fzf (fuzzy), substring, regexp, smartcase
848+
Examples: fzf (fuzzy matching)
846849

847850
*fall-module-curator*
848851
Curator~
@@ -859,7 +862,7 @@ Sorter~
859862
can be chained to create complex sorting behaviors.
860863

861864
Interface: (items) -> void (sorts in-place)
862-
Examples: alphabetical, length, score, mtime
865+
Examples: noop (no sorting), lexical (alphabetical)
863866

864867
*fall-module-renderer*
865868
Renderer~
@@ -868,15 +871,15 @@ Renderer~
868871
modifying the underlying data.
869872

870873
Interface: (items) -> void (modifies display properties)
871-
Examples: nerdfont (adds icons), filename (path formatting)
874+
Examples: nerdfont (adds icons), smartPath (intelligent path display)
872875

873876
*fall-module-previewer*
874877
Previewer~
875878
Generates preview content for the currently selected item. Previewers
876879
can display file contents, documentation, or any relevant information.
877880

878881
Interface: (item) -> PreviewContent
879-
Examples: file (with syntax), buffer, help
882+
Examples: file (with syntax highlighting), buffer, helptag
880883

881884
*fall-module-action*
882885
Action~
@@ -916,9 +919,9 @@ Common Issues~
916919
- Disable preview for large files
917920

918921
4. Custom source not working
919-
- Validate TypeScript syntax: `:FallCustomCheck`
920922
- Ensure source returns proper item structure
921923
- Check Deno console for runtime errors
924+
- Review TypeScript syntax errors in the editor
922925

923926
5. Key mappings not working
924927
- Confirm no conflicts: `:verbose cmap <key>`
@@ -935,10 +938,6 @@ View Denops server output:
935938
>vim
936939
:DenopsServer
937940
<
938-
Check custom file syntax:
939-
>vim
940-
:FallCustomCheck
941-
<
942941
=============================================================================
943942
EXAMPLES *fall-examples*
944943

0 commit comments

Comments
 (0)