fix: optimize java

Author: vitali87

codebase_rag/language_config.py

@@ -249,9 +249,6 @@ class LanguageConfig:
         call_query="""
         (method_invocation
             name: (identifier) @name) @call
-        (method_invocation
-            object: (_)
-            name: (identifier) @name) @call
         (object_creation_expression
             type: (type_identifier) @name) @call
         """,

codebase_rag/parsers/definition_processor.py

@@ -1178,6 +1178,25 @@ def _ingest_classes_and_methods(
                 if not isinstance(method_node, Node):
                     continue
 
+                # Handle Java method overloading with parameter types
+                method_qualified_name = None
+                if language == "java":
+                    from .java_utils import extract_java_method_info
+
+                    method_info = extract_java_method_info(method_node)
+                    method_name = method_info.get("name")
+                    parameters = method_info.get("parameters", [])
+                    if method_name:
+                        if parameters:
+                            # Create method signature with parameter types for overloading
+                            param_signature = "(" + ",".join(parameters) + ")"
+                            method_qualified_name = (
+                                f"{class_qn}.{method_name}{param_signature}"
+                            )
+                        else:
+                            # No parameters, use simple name
+                            method_qualified_name = f"{class_qn}.{method_name}()"
+
                 ingest_method(
                     method_node,
                     class_qn,
@@ -1188,6 +1207,7 @@ def _ingest_classes_and_methods(
                     self._get_docstring,
                     language,
                     self._extract_decorators,
+                    method_qualified_name,
                 )
 
                 # Note: OVERRIDES relationships will be processed later after all methods are collected

codebase_rag/parsers/java_type_inference.py

@@ -8,6 +8,7 @@
 
 from .import_processor import ImportProcessor
 from .java_utils import (
+    extract_java_class_info,
     extract_java_field_info,
     extract_java_method_call_info,
     safe_decode_text,
@@ -1115,7 +1116,6 @@ def _find_field_type_in_class(
         self, root_node: Node, class_name: str, field_name: str, module_qn: str
     ) -> str | None:
         """Find the type of a specific field in a class using tree-sitter AST analysis."""
-        from .java_utils import extract_java_class_info, extract_java_field_info
 
         # Find the target class in the AST
         for child in root_node.children:

codebase_rag/parsers/utils.py

@@ -92,6 +92,7 @@ def ingest_method(
     get_docstring_func: Any,
     language: str = "",
     extract_decorators_func: Any = None,
+    method_qualified_name: str | None = None,
 ) -> None:
     """Ingest a method node into the graph database.
 
@@ -105,6 +106,7 @@ def ingest_method(
         get_docstring_func: Function to extract docstring from a node.
         language: The programming language (used for C++ specific handling).
         extract_decorators_func: Optional function to extract decorators.
+        method_qualified_name: Optional pre-computed qualified name to use instead of generating one.
     """
     # Extract method name based on language
     if language == "cpp":
@@ -122,20 +124,12 @@ def ingest_method(
             return
         method_name = text.decode("utf8")
 
-    # Build qualified name (handle Java method overloading)
-    if language == "java":
-        from .java_utils import extract_java_method_info
-
-        method_info = extract_java_method_info(method_node)
-        parameters = method_info.get("parameters", [])
-        if parameters:
-            # Create method signature with parameter types for overloading
-            param_signature = "(" + ",".join(parameters) + ")"
-            method_qn = f"{container_qn}.{method_name}{param_signature}"
-        else:
-            # No parameters, use simple name
-            method_qn = f"{container_qn}.{method_name}()"
+    # Build qualified name
+    if method_qualified_name is not None:
+        # Use pre-computed qualified name (for language-specific handling)
+        method_qn = method_qualified_name
     else:
+        # Default qualified name construction
         method_qn = f"{container_qn}.{method_name}"
 
     # Extract decorators if function provided