Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deno + Vite: TS starter working but not JS #377

Closed
7 tasks done
mbrahimi02 opened this issue Oct 20, 2024 · 2 comments
Closed
7 tasks done

Deno + Vite: TS starter working but not JS #377

mbrahimi02 opened this issue Oct 20, 2024 · 2 comments

Comments

@mbrahimi02
Copy link

Describe the bug

I'm creating a deno project with site using deno run -A npm:create-vite-extra and all works fine if I select the TS project. If I select the JS project, I get the following despite the fact that types are installed and configured by default:

TypeError: createRoot is not a function. (In 'createRoot(document.getElementById("root"))', 'createRoot' is undefined)

Reproduction

I can't add bc there's no way to select runtime

Steps to reproduce

deno run -A npm:create-vite-extra with JavaScript project

System Info

System:
    OS: macOS 15.0.1
    CPU: Unknown
    Memory: 48.11 KB / 16.00 GB
    Shell: 5.9 - /bin/zsh
  Browsers:
    Safari: 18.0.1

Used Package Manager

npm

Logs

No response

Validations

@ArnaudBarre
Copy link
Member

That's an oversight from @bluwy in bluwy/create-vite-extra@fcaf8b1, createRoot should be imported from react-dom and StrictMode from react

@bluwy
Copy link
Member

bluwy commented Oct 21, 2024

My bad. Will fix that in the next release

@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants