Skip to content

Commit 1550cd6

Browse files
committed
Validates that that image exists for commit
Otherwise, falls back to building image and wheel. Signed-off-by: dougbtv <[email protected]>
1 parent 2191a18 commit 1550cd6

File tree

1 file changed

+23
-12
lines changed

1 file changed

+23
-12
lines changed

buildkite/bootstrap.sh

Lines changed: 23 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -183,21 +183,32 @@ else
183183
SKIP_IMAGE_BUILD=0
184184
fi
185185
fi
186-
echo "Final SKIP_IMAGE_BUILD=${SKIP_IMAGE_BUILD} (RUN_ALL=${RUN_ALL}, VLLM_USE_PRECOMPILED=${VLLM_USE_PRECOMPILED:-unset})"
187186

188-
# Select Docker image based on latest common ancestor (LCA) commit between current branch and main
189-
LCA_COMMIT=""
190-
if git rev-parse --is-inside-work-tree >/dev/null 2>&1; then
191-
LCA_COMMIT=$(git merge-base origin/main HEAD)
192-
fi
193-
if [[ -n "$LCA_COMMIT" ]]; then
194-
DOCKER_IMAGE_OVERRIDE="public.ecr.aws/q9t5s3a7/vllm-ci-postmerge-repo:$LCA_COMMIT"
195-
echo "Using Docker image for LCA commit: $DOCKER_IMAGE_OVERRIDE"
196-
else
197-
DOCKER_IMAGE_OVERRIDE="public.ecr.aws/q9t5s3a7/vllm-ci-postmerge-repo:latest"
198-
echo "Could not determine LCA commit, using latest Docker image: $DOCKER_IMAGE_OVERRIDE"
187+
# Determine the lowest common ancestor (LCA) commit with main branch if skipping image build
188+
if [[ "${SKIP_IMAGE_BUILD}" == "1" ]]; then
189+
LCA_COMMIT=""
190+
if git rev-parse --is-inside-work-tree >/dev/null 2>&1; then
191+
LCA_COMMIT=$(git merge-base origin/main HEAD)
192+
fi
193+
if [[ -n "$LCA_COMMIT" ]]; then
194+
IMAGE_TAG="public.ecr.aws/q9t5s3a7/vllm-ci-postmerge-repo:$LCA_COMMIT"
195+
# Check if the image exists on the registry
196+
if docker manifest inspect "$IMAGE_TAG" >/dev/null 2>&1; then
197+
DOCKER_IMAGE_OVERRIDE="$IMAGE_TAG"
198+
echo "Using Docker image for LCA commit: $DOCKER_IMAGE_OVERRIDE"
199+
else
200+
echo "LCA image not found, falling back to build image"
201+
SKIP_IMAGE_BUILD=0
202+
VLLM_USE_PRECOMPILED=0
203+
fi
204+
else
205+
DOCKER_IMAGE_OVERRIDE="public.ecr.aws/q9t5s3a7/vllm-ci-postmerge-repo:latest"
206+
echo "Could not determine LCA commit, using latest Docker image: $DOCKER_IMAGE_OVERRIDE"
207+
fi
199208
fi
200209

210+
echo "Final SKIP_IMAGE_BUILD=${SKIP_IMAGE_BUILD} (RUN_ALL=${RUN_ALL}, VLLM_USE_PRECOMPILED=${VLLM_USE_PRECOMPILED:-unset})"
211+
201212
################## end WIP #####################
202213

203214
LIST_FILE_DIFF=$(get_diff | tr ' ' '|')

0 commit comments

Comments
 (0)