Skip to content

Conversation

@kylesayrs
Copy link
Collaborator

@kylesayrs kylesayrs commented Dec 5, 2025

Purpose

  • These utils haven't been used in almost two years. Let's deprecate them before the next release

After Release

Signed-off-by: Kyle Sayers <[email protected]>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @kylesayrs, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request initiates the deprecation process for a collection of utility functions in src/llmcompressor/utils/helpers.py that have been identified as unused for an extended period. The primary goal is to streamline the codebase by marking these functions for eventual removal after the next release, thereby improving maintainability and reducing technical debt. Users who still rely on these functions will now encounter deprecation warnings, guiding them towards alternative solutions or updated APIs.

Highlights

  • Deprecation of Unused Utilities: A significant number of utility functions within src/llmcompressor/utils/helpers.py have been marked as deprecated. This action targets functions that have not been actively used for approximately two years.
  • Introduction of deprecated decorator: The @deprecated() decorator from compressed_tensors.utils has been imported and applied to the identified unused functions, signaling their planned removal in a future release.
  • Specific Replacements Noted: For interpolation-related functions (interpolate, interpolate_list_linear, interpolated_integral), the deprecation decorator explicitly suggests torch.lerp as a future replacement.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request deprecates a large number of unused utility functions, which is a great cleanup effort. The changes are mostly straightforward additions of the @deprecated decorator. I've found a few areas for improvement:

  • One of the deprecated functions has an incorrect future_name suggesting a wrong replacement.
  • For another function, the suggested replacement is only valid for one of its modes of operation.
  • I've also added suggestions for improving clarity around the deprecation of a class and noted a side effect of deprecating the deprecation_warning function.

Overall, these are good changes that will improve the maintainability of the codebase.

Signed-off-by: Kyle Sayers <[email protected]>
Signed-off-by: Kyle Sayers <[email protected]>
@kylesayrs kylesayrs added the ready When a PR is ready for review label Dec 5, 2025
@github-actions
Copy link

github-actions bot commented Dec 5, 2025

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed.

@dsikka dsikka enabled auto-merge (squash) December 8, 2025 22:22
@dsikka dsikka merged commit 4982529 into main Dec 8, 2025
11 checks passed
@dsikka dsikka deleted the kylesayrs/deprecate branch December 8, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready When a PR is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants