Skip to content

Commit a5f96b8

Browse files
update run_in_docker script for running on local env (#1243)
Signed-off-by: ernie-chang <[email protected]> Co-authored-by: Sting Lin <[email protected]>
1 parent ae5dd2e commit a5f96b8

File tree

1 file changed

+12
-8
lines changed

1 file changed

+12
-8
lines changed

.buildkite/scripts/setup_docker_env.sh

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,6 @@ setup_environment() {
1818
# shellcheck disable=1091
1919
source /etc/environment
2020

21-
if [ -z "${BUILDKITE_COMMIT:-}" ]; then
22-
echo "ERROR: BUILDKITE_COMMIT environment variable is not set." >&2
23-
echo "This script expects BUILDKITE_COMMIT to tag the Docker image." >&2
24-
exit 1
25-
fi
26-
2721
# Cleanup of existing containers and images.
2822
echo "Starting cleanup for ${IMAGE_NAME}..."
2923
# Get all unique image IDs for the repository
@@ -55,10 +49,20 @@ setup_environment() {
5549

5650
echo "Cleanup complete."
5751

58-
VLLM_COMMIT_HASH=$(buildkite-agent meta-data get "VLLM_COMMIT_HASH" --default "")
52+
echo "Installing Python dependencies"
53+
python3 -m pip install --progress-bar off buildkite-test-collector==0.1.9
54+
echo "Python dependencies installed"
55+
if [ -z "${BUILDKITE:-}" ]; then
56+
VLLM_COMMIT_HASH=""
57+
TPU_INFERENCE_HASH=$(git log -n 1 --pretty="%H")
58+
else
59+
VLLM_COMMIT_HASH=$(buildkite-agent meta-data get "VLLM_COMMIT_HASH" --default "")
60+
TPU_INFERENCE_HASH="$BUILDKITE_COMMIT"
61+
fi
5962

6063
docker build \
6164
--build-arg VLLM_COMMIT_HASH="${VLLM_COMMIT_HASH}" \
6265
--build-arg IS_FOR_V7X="${IS_FOR_V7X:-false}" \
63-
--no-cache -f docker/Dockerfile -t "${IMAGE_NAME}:${BUILDKITE_COMMIT}" .
66+
--no-cache -f docker/Dockerfile -t "${IMAGE_NAME}:${TPU_INFERENCE_HASH}" .
67+
6468
}

0 commit comments

Comments
 (0)