Skip to content

Commit ff78139

Browse files
committed
Update script
Signed-off-by: ernie-chang <[email protected]>
1 parent 4c67fc4 commit ff78139

File tree

2 files changed

+4
-10
lines changed

2 files changed

+4
-10
lines changed

.buildkite/scripts/run_in_docker.sh

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,6 @@ else
4848
exit 1
4949
fi
5050

51-
if [ -z "${BUILDKITE_COMMIT:-}" ]; then
52-
COMMIT="tmp"
53-
else
54-
COMMIT="$BUILDKITE_COMMIT"
55-
fi
56-
5751
exec docker run \
5852
--privileged \
5953
--net host \
@@ -71,5 +65,5 @@ exec docker run \
7165
${USE_V6E8_QUEUE:+-e USE_V6E8_QUEUE="$USE_V6E8_QUEUE"} \
7266
${SKIP_ACCURACY_TESTS:+-e SKIP_ACCURACY_TESTS="$SKIP_ACCURACY_TESTS"} \
7367
${VLLM_MLA_DISABLE:+-e VLLM_MLA_DISABLE="$VLLM_MLA_DISABLE"} \
74-
"${IMAGE_NAME}:${COMMIT}" \
68+
"${IMAGE_NAME}:${BUILDKITE_COMMIT}" \
7569
"$@" # Pass all script arguments as the command to run in the container

.buildkite/scripts/setup_docker_env.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ setup_environment() {
2020

2121
# If the script run on the buildkite agent, will use $BUILDKITE_COMMIT as a tag.
2222
# Otherwise, if run on local vm, just use "tmp" as a tag.
23-
image_tag="${BUILDKITE_COMMIT:-tmp}"
2423

2524
# Cleanup of existing containers and images.
2625
echo "Starting cleanup for ${IMAGE_NAME}..."
@@ -56,14 +55,15 @@ setup_environment() {
5655
echo "Installing Python dependencies"
5756
python3 -m pip install --progress-bar off buildkite-test-collector==0.1.9
5857
echo "Python dependencies installed"
59-
if [ -z "${BUILDKITE_COMMIT:-}" ]; then
58+
if [ -z "${BUILDKITE:-}" ]; then
6059
VLLM_COMMIT_HASH=""
60+
BUILDKITE_COMMIT="tmp"
6161
else
6262
VLLM_COMMIT_HASH="28097d5638cc695f4644c411edac8eb05a03b39b"
6363
#VLLM_COMMIT_HASH=$(buildkite-agent meta-data get "VLLM_COMMIT_HASH" --default "")
6464
fi
6565

6666
docker build \
6767
--build-arg VLLM_COMMIT_HASH="${VLLM_COMMIT_HASH}" \
68-
--no-cache -f docker/Dockerfile -t "${IMAGE_NAME}:${image_tag}" .
68+
--no-cache -f docker/Dockerfile -t "${IMAGE_NAME}:${BUILDKITE_COMMIT}" .
6969
}

0 commit comments

Comments
 (0)