Skip to content

Commit bae973d

Browse files
fix: remove Cloudsmith from active benchmark runs
Cloudsmith is no longer supported as a test registry. Remove it from: - Default registry list in bench script and scripts/registry/common.sh - Hyperfine commands in registry-clean.sh and registry-lockfile.sh - CI workflow environment variables in benchmark.yaml Historical Cloudsmith data, UI components, chart colors, and type definitions are preserved so existing results continue to display. Active registries are now: npm, vlt, aws, github Co-authored-by: Darcy Clarke <darcy@darcyclarke.me>
1 parent 2eaa9b9 commit bae973d

5 files changed

Lines changed: 3 additions & 13 deletions

File tree

.github/workflows/benchmark.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -147,8 +147,6 @@ jobs:
147147
env:
148148
CODEARTIFACT_AUTH_TOKEN: ${{ steps.aws.outputs.token }}
149149
VLT_REGISTRY_AUTH_TOKEN: ${{ secrets.VLT_REGISTRY_AUTH_TOKEN }}
150-
CLOUDSMITH_REGISTRY: ${{ secrets.CLOUDSMITH_REGISTRY }}
151-
CLOUDSMITH_AUTH_TOKEN: ${{ secrets.CLOUDSMITH_AUTH_TOKEN }}
152150
GH_REGISTRY: ${{ secrets.GH_REGISTRY }}
153151
GH_AUTH_TOKEN: ${{ secrets.GH_AUTH_TOKEN }}
154152
BENCH_WARMUP: ${{ steps.tune.outputs.warmup }}

bench

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ AVAILABLE_REGISTRIES=(
4343
npm
4444
vlt
4545
aws
46-
cloudsmith
4746
github
4847
)
4948

@@ -58,7 +57,7 @@ Usage:
5857
Options:
5958
--fixtures Comma or space-separated fixture names (default: next)
6059
--pms Comma or space-separated package managers (default: all)
61-
--registries Comma-separated registries for registry-* variations (default: npm,vlt,aws,cloudsmith,github)
60+
--registries Comma-separated registries for registry-* variations (default: npm,vlt,aws,github)
6261
--variation Comma or space-separated benchmark variations (default: clean)
6362
--runs Hyperfine runs (default: scripts/variations/common.sh default)
6463
--warmup Hyperfine warmup runs (default: scripts/variations/common.sh default)
@@ -80,7 +79,6 @@ Examples:
8079
./bench run --variation=registry-clean --fixtures=next
8180
./bench run --variation=registry-lockfile --registries=npm,vlt
8281
CODEARTIFACT_AUTH_TOKEN=<token> ./bench run --variation=registry-clean --fixtures=next --registries=aws
83-
CLOUDSMITH_REGISTRY=<url> CLOUDSMITH_AUTH_TOKEN=<token> ./bench run --variation=registry-clean --fixtures=next --registries=cloudsmith
8482
GH_REGISTRY=<url> GH_AUTH_TOKEN=<token> ./bench run --variation=registry-clean --fixtures=next --registries=github
8583
./bench chart --fixtures=next --variation=clean
8684
./bench process
@@ -461,7 +459,7 @@ run_bench() {
461459
if [[ -n "$registries_env" ]]; then
462460
echo " registries: $registries_env"
463461
else
464-
echo " registries: npm,vlt,aws,cloudsmith,github (default)"
462+
echo " registries: npm,vlt,aws,github (default)"
465463
fi
466464
fi
467465

scripts/registry/common.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ BENCH_COMMAND_GITHUB="timeout $BENCH_TIMEOUT $BENCH_NPM_INSTALL >> $BENCH_OUTPUT
119119
# Registry include flags
120120
# If BENCH_INCLUDE_REGISTRY is not set, default to running all registries.
121121
if [ -z "${BENCH_INCLUDE_REGISTRY:-}" ]; then
122-
BENCH_INCLUDE_REGISTRY="npm,vlt,aws,cloudsmith,github"
122+
BENCH_INCLUDE_REGISTRY="npm,vlt,aws,github"
123123
fi
124124

125125
BENCH_INCLUDE_REG_NPM=""

scripts/variations/registry-clean.sh

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,6 @@ hyperfine --ignore-failure \
2626
${BENCH_INCLUDE_REG_AWS:+--prepare="$BENCH_PREPARE_BASE && $BENCH_SETUP_REGISTRY_AWS"} \
2727
${BENCH_INCLUDE_REG_AWS:+--command-name="aws" "$BENCH_COMMAND_AWS"} \
2828
${BENCH_INCLUDE_REG_AWS:+--conclude="$BENCH_CONCLUDE_AWS"} \
29-
${BENCH_INCLUDE_REG_CLOUDSMITH:+--prepare="$BENCH_PREPARE_BASE && $BENCH_SETUP_REGISTRY_CLOUDSMITH"} \
30-
${BENCH_INCLUDE_REG_CLOUDSMITH:+--command-name="cloudsmith" "$BENCH_COMMAND_CLOUDSMITH"} \
31-
${BENCH_INCLUDE_REG_CLOUDSMITH:+--conclude="$BENCH_CONCLUDE_CLOUDSMITH"} \
3229
${BENCH_INCLUDE_REG_GITHUB:+--prepare="$BENCH_PREPARE_BASE && $BENCH_SETUP_REGISTRY_GITHUB"} \
3330
${BENCH_INCLUDE_REG_GITHUB:+--command-name="github" "$BENCH_COMMAND_GITHUB"} \
3431
${BENCH_INCLUDE_REG_GITHUB:+--conclude="$BENCH_CONCLUDE_GITHUB"}

scripts/variations/registry-lockfile.sh

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,6 @@ hyperfine --ignore-failure \
2727
${BENCH_INCLUDE_REG_AWS:+--prepare="$BENCH_PREPARE_BASE && $BENCH_SETUP_REGISTRY_AWS"} \
2828
${BENCH_INCLUDE_REG_AWS:+--command-name="aws" "$BENCH_COMMAND_AWS"} \
2929
${BENCH_INCLUDE_REG_AWS:+--conclude="$BENCH_CONCLUDE_AWS"} \
30-
${BENCH_INCLUDE_REG_CLOUDSMITH:+--prepare="$BENCH_PREPARE_BASE && $BENCH_SETUP_REGISTRY_CLOUDSMITH"} \
31-
${BENCH_INCLUDE_REG_CLOUDSMITH:+--command-name="cloudsmith" "$BENCH_COMMAND_CLOUDSMITH"} \
32-
${BENCH_INCLUDE_REG_CLOUDSMITH:+--conclude="$BENCH_CONCLUDE_CLOUDSMITH"} \
3330
${BENCH_INCLUDE_REG_GITHUB:+--prepare="$BENCH_PREPARE_BASE && $BENCH_SETUP_REGISTRY_GITHUB"} \
3431
${BENCH_INCLUDE_REG_GITHUB:+--command-name="github" "$BENCH_COMMAND_GITHUB"} \
3532
${BENCH_INCLUDE_REG_GITHUB:+--conclude="$BENCH_CONCLUDE_GITHUB"}

0 commit comments

Comments
 (0)