Conversation
Alja9
marked this pull request as draft
June 5, 2026 03:06
Alja9
marked this pull request as ready for review
June 14, 2026 01:49
jenting
previously approved these changes
Jun 14, 2026
Signed-off-by: aldi.j <aldi.jayadi222@gmail.com>
jenting
previously approved these changes
Jun 15, 2026
Signed-off-by: aldi.j <aldi.jayadi222@gmail.com>
jenting
approved these changes
Sep 30, 2026
Collaborator
|
@blackpiglet PTAL |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Special notes for your reviewer:
Fixed the lifecycle condition in
templates/node-agent-daemonset.yaml.The condition now correctly checks
.Values.nodeAgent.lifecycleinstead of.Values.lifecycle.So the nodeAgent lifecycle is only rendered when the nodeAgent lifecycle is actually configured in
values.yaml:helm-charts/charts/velero/values.yaml
Lines 747 to 748 in beb24e2
Not when the Velero deployment lifecycle is set.
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[velero])