Remove public-api lockfiles

Signed-off-by: Adam Gutglick <adam@spiraldb.com>

Author: AdamGS

.agents/skills/pr-review/SKILL.md

@@ -60,16 +60,16 @@ network permissions.
 
 ## Review Areas
 
-| Area | Focus |
-| --- | --- |
-| Correctness | Length and dtype invariants, nullability, validity masks, offset math, canonicalization, boundary conditions, empty arrays, scalar vs array behavior |
-| Rust soundness | `unsafe` blocks, aliasing, lifetimes, alignment, FFI boundaries, panic safety, ownership of buffers and arrays |
-| Compression and IO | Encoding metadata, statistics, layout evolution, file compatibility, scan projection/filter behavior, async IO edge cases |
-| Performance | Unnecessary copies, lost zero-copy behavior, avoidable allocations, poor cache locality, quadratic loops, excessive dynamic dispatch in hot paths |
-| Error handling | Correct `vortex_err!` and `vortex_bail!` usage, useful messages, no accidental panics on user data |
-| API compatibility | Public API docs, public-api lock updates, feature flags, crate boundaries, Python/Java binding impacts |
-| Tests | Regression coverage, edge cases, parameterized cases with `rstest`, use of `assert_arrays_eq!`, docs doctests when docs change |
-| Verification scope | Avoid requesting or running expensive workspace checks when the PR only changes docs, agent files, symlinks, or metadata |
+| Area               | Focus                                                                                                                                                |
+| ------------------ | ---------------------------------------------------------------------------------------------------------------------------------------------------- |
+| Correctness        | Length and dtype invariants, nullability, validity masks, offset math, canonicalization, boundary conditions, empty arrays, scalar vs array behavior |
+| Rust soundness     | `unsafe` blocks, aliasing, lifetimes, alignment, FFI boundaries, panic safety, ownership of buffers and arrays                                       |
+| Compression and IO | Encoding metadata, statistics, layout evolution, file compatibility, scan projection/filter behavior, async IO edge cases                            |
+| Performance        | Unnecessary copies, lost zero-copy behavior, avoidable allocations, poor cache locality, quadratic loops, excessive dynamic dispatch in hot paths    |
+| Error handling     | Correct `vortex_err!` and `vortex_bail!` usage, useful messages, no accidental panics on user data                                                   |
+| API compatibility  | Public API docs, feature flags, crate boundaries, Python/Java binding impacts                                                                        |
+| Tests              | Regression coverage, edge cases, parameterized cases with `rstest`, use of `assert_arrays_eq!`, docs doctests when docs change                       |
+| Verification scope | Avoid requesting or running expensive workspace checks when the PR only changes docs, agent files, symlinks, or metadata                             |
 
 ## Output
 

.github/AGENTS.md

@@ -4,7 +4,6 @@ Nightly is required for:
 - `cargo fmt` (nightly formatting options)
 - `-Z` flags: sanitizers (`-Zsanitizer=address`), miri (`-Zmiri-*`), publish (`-Zpublish-timeout`)
 - `cargo-fuzz` (requires nightly)
-- `public-api` xtask (nightly rustdoc JSON)
 
 Everything else (build, clippy, tests, docs, benchmarks, packaging) should use stable.
 

.github/pull_request_template.md

@@ -39,8 +39,7 @@ Consider whether the change affects users in one of the following ways:
 3. Should some documentation be updated to reflect this change?
 
 If a public API is changed in a breaking manner, make sure to add the
-appropriate label. You can run `./scripts/public-api.sh` locally to see if there
-are any public API changes (and this also runs in our CI).
+appropriate label.
 -->
 
 ## Testing

.github/workflows/ci.yml

@@ -294,40 +294,6 @@ jobs:
         run: |
           cargo hack --no-dev-deps --ignore-private clippy --profile ci --no-default-features -- -D warnings
 
-  public-api:
-    name: "Public API lock files"
-    timeout-minutes: 30
-    runs-on: >-
-      ${{ github.repository == 'vortex-data/vortex'
-          && format('runs-on={0}/runner=amd64-xsmall/image=ubuntu24-full-x64-pre-v2/tag=public-api', github.run_id)
-          || 'ubuntu-latest' }}
-    steps:
-      - uses: runs-on/action@v2
-        if: github.repository == 'vortex-data/vortex'
-        with:
-          sccache: s3
-      - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd  # v6
-      - uses: ./.github/actions/setup-prebuild
-      - name: Install nightly for public-api
-        run: rustup toolchain install $NIGHTLY_TOOLCHAIN
-      - name: Regenerate public API lock files
-        run: cargo +$NIGHTLY_TOOLCHAIN run --profile ci -p xtask -- public-api
-      - name: Verify lock files are up to date
-        run: |
-          if ! git diff --quiet '**/public-api.lock'; then
-            git diff -U0 '**/public-api.lock'
-            echo ""
-            echo ""
-            echo "Changed files:"
-            git diff --name-only '**/public-api.lock'
-            echo ""
-            echo ""
-            echo "Public API lock files are out of date."
-            echo "Run './scripts/public-api.sh' locally to"
-            echo "regenerate them, then commit the changes."
-            exit 1
-          fi
-
   rust-test-other:
     name: "Rust tests (${{ matrix.os }})"
     timeout-minutes: 30

AGENTS.md

@@ -110,14 +110,11 @@ For Rust code, public API, feature flag, or generated-file changes, run these be
 
 ```bash
 cargo +nightly fmt --all
-./scripts/public-api.sh
 cargo clippy --all-targets --all-features
 ```
 
 Notes:
 
-- `./scripts/public-api.sh` regenerates all `public-api.lock` files through the `xtask`
-  wrapper. Run it when public Rust APIs may have changed, not for docs-only or agent-only edits.
 - For `.github/` changes, follow `.github/AGENTS.md` and run
   `yamllint --strict -c .yamllint.yaml` on changed workflow files.
 - You can try
@@ -173,9 +170,6 @@ Notes:
 
 Check new and modified lines against this list before finishing:
 
-- Public API changes without doc comments or refreshed `public-api.lock` files.
-- Running `cargo fmt`, `./scripts/public-api.sh`, or workspace clippy for docs-only, agent-only,
-  symlink-only, or other metadata-only changes.
 - Running broad CI-style commands before trying a narrow local repro.
 - Using `unwrap`, `expect`, or panic-oriented assertions in tests where `VortexResult<()>` and
   `?` would be clearer.

Cargo.lock

@@ -203,7 +203,6 @@ proc-macro2 = "1.0.95"
 prost = "0.14"
 prost-build = "0.14"
 prost-types = "0.14"
-public-api = { git = "https://github.com/vortex-data/cargo-public-api.git", branch = "main" }
 pyo3 = { version = "0.28.0" }
 pyo3-bytes = "0.6"
 pyo3-log = "0.13.0"

Cargo.toml

@@ -16,7 +16,7 @@ path = "src/main.rs"
 
 # Throwaway binary, not part of the vortex-* public API surface.
 # Errors use anyhow, and the crate is intentionally outside the
-# workspace public-api lockfile set.
+# workspace.
 
 [dependencies]
 anyhow = { workspace = true }

benchmarks-website/migrate/Cargo.toml

@@ -20,7 +20,7 @@ path = "src/main.rs"
 
 # This is a leaf binary, not part of the vortex-* public API surface.
 # Errors use anyhow / thiserror and the crate is intentionally outside
-# the workspace public-api lockfile set.
+# the workspace.
 
 [dependencies]
 anyhow = { workspace = true }
@@ -39,9 +39,19 @@ serde = { workspace = true, features = ["derive", "rc"] }
 serde_json = { workspace = true }
 subtle = "2.6"
 thiserror = { workspace = true }
-tokio = { workspace = true, features = ["rt-multi-thread", "macros", "net", "signal", "sync"] }
+tokio = { workspace = true, features = [
+    "rt-multi-thread",
+    "macros",
+    "net",
+    "signal",
+    "sync",
+] }
 tower = "0.5"
-tower-http = { version = "0.6", features = ["compression-br", "compression-gzip", "trace"] }
+tower-http = { version = "0.6", features = [
+    "compression-br",
+    "compression-gzip",
+    "trace",
+] }
 tracing = { workspace = true, features = ["std"] }
 tracing-subscriber = { workspace = true, features = ["env-filter", "fmt"] }
 twox-hash = "2.1"