Skip to content

Commit 8c26832

Browse files
committed
Halve listview zip bench LEN to stay under CodSpeed simulation budget
CodSpeed's instruction-count simulation runs ~10x local walltime, putting the 8192-list bench at ~550us there. Drop to 4096 lists so each case stays well under a few hundred microseconds in CI while still exercising the select. Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
1 parent 21b59cf commit 8c26832

2 files changed

Lines changed: 5 additions & 4 deletions

File tree

vortex-array/benches/listview_zip.rs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,10 @@ fn main() {
2121
}
2222

2323
// Smaller than the value-path benches: listview zip cost is dominated by element concatenation and
24-
// per-list canonicalization, so a few thousand lists already exercises the select while keeping the
25-
// benchmark well under a few hundred microseconds.
26-
const LEN: usize = 8_192;
24+
// per-list canonicalization. A few thousand lists already exercise the select while keeping each
25+
// case well under a few hundred microseconds under CodSpeed's instruction-count simulation, which
26+
// runs ~10x the local walltime.
27+
const LEN: usize = 4_096;
2728

2829
/// Fragmented (alternating) mask: the worst case for the per-element branch this kernel replaces.
2930
/// The branchless chunked select is mask-shape-independent, so one shape suffices.

vortex-array/src/arrays/listview/compute/zip.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -450,7 +450,7 @@ mod tests {
450450
sizes.iter().copied().collect::<Buffer<u64>>().into_array(),
451451
Validity::NonNullable,
452452
);
453-
assert_arrays_eq!(result, expected);
453+
assert_arrays_eq!(result, expected, &mut ctx);
454454
Ok(())
455455
}
456456

0 commit comments

Comments
 (0)