@@ -201,7 +201,7 @@ and ratios against the selected baseline target or the first target in each quer
201201## Summarizing Mask/Row-Demand Logs
202202
203203When a run emits Vortex mask-style debug lines, summarize them before reading more code. This
204- includes V2 ` vortex_layout::mask_debug ` rows and V1 pruning rows with the same coordinate fields.
204+ includes mask-debug rows and pruning rows with the same coordinate fields.
205205These logs are useful for deciding whether a hot stack is expensive per row, called over too many
206206rows, or repeated over the same coordinates:
207207
@@ -218,8 +218,8 @@ If a low-selectivity filter still shows very large input batches late in the pip
218218with the Samply timeline: a few huge all-false batches can explain idle workers even when total row
219219work looks reasonable.
220220
221- For conjunct scheduling logs, aggregate compute rows per predicate. This handles V2 conjunct rows
222- and V1 pruning/filter conjunct rows when the logs include comparable fields:
221+ For conjunct scheduling logs, aggregate compute rows per predicate. This handles candidate
222+ conjunct rows and baseline pruning/filter conjunct rows when the logs include comparable fields:
223223
224224``` bash
225225python3 .agents/skills/bench-performance/scripts/summarize_conjunct_debug.py \
@@ -229,16 +229,16 @@ python3 .agents/skills/bench-performance/scripts/summarize_conjunct_debug.py \
229229Use this when checking whether a pushed-down or shared mask is actually evaluated once, or whether
230230each projected field is driving the same conjunct work again.
231231
232- When investigating V2 stream scheduling, enable the flow trace and summarize it immediately:
232+ When investigating stream scheduling, enable the relevant flow trace and summarize it immediately:
233233
234234``` bash
235- VORTEX_V2_TRACE_FLOW =1 RUST_LOG=vortex_layout::v2:: flow=debug,datafusion=warn \
235+ < FLOW_TRACE_ENV > =1 RUST_LOG=< flow-target > =debug,datafusion=warn \
236236 target/< profile-dir> /datafusion-bench clickbench \
237237 --display-format gh-json --iterations 1 --hide-progress-bar \
238238 --formats vortex --queries < query> \
239239 -o /private/tmp/< label> .jsonl > /private/tmp/< label> .log 2>&1
240240
241- python3 .agents/skills/bench-performance/scripts/summarize_v2_flow .py \
241+ python3 .agents/skills/bench-performance/scripts/summarize_flow_tracing .py \
242242 /private/tmp/< label> .log
243243```
244244
@@ -325,7 +325,7 @@ rows. Add temporary trace/debug fields that make each compute event joinable:
325325 ranges;
326326- a deterministic hash of the absolute survivor row set for same-window checks;
327327- partition-independent fingerprints such as wrapping row-id sum and row-id xor so unions can be
328- compared when V1 and V2 use different batch boundaries.
328+ compared when two paths use different batch boundaries.
329329
330330Be careful with multi-file benchmarks: ` row_start=0..N ` is only meaningful with a file label. Be
331331careful with nested layouts too: child plans may log local coordinates unless the diagnostic uses
@@ -334,12 +334,12 @@ the same file differently, identical `(file, row_range)` keys may not exist; com
334334input/output row counts first, then add a union-level dump only if exact row-set equality is still
335335unclear.
336336
337- Prefer diagnostic logs over changing public batch types. Useful log points are final V1 split
338- projection, V2 mask/filter nodes, and filtered V2 leaf projection nodes. For each batch-like event,
339- emit the input coordinate window plus the post-mask survivor summary/hash; that lets you compare
340- exact row sets even when physical batch boundaries differ. Avoid logging every unfiltered leaf by
341- default: nested layouts such as dictionary values may live in a different row space and can drown
342- out the scan-coordinate signal.
337+ Prefer diagnostic logs over changing public batch types. Useful log points are final baseline split
338+ projection, candidate mask/filter nodes, and filtered candidate leaf projection nodes. For each
339+ batch-like event, emit the input coordinate window plus the post-mask survivor summary/hash; that
340+ lets you compare exact row sets even when physical batch boundaries differ. Avoid logging every
341+ unfiltered leaf by default: nested layouts such as dictionary values may live in a different row
342+ space and can drown out the scan-coordinate signal.
343343
344344## Samply
345345
0 commit comments