don't redownload duckdb for every branch

Signed-off-by: Mikhail Kot <to@myrrc.dev>

Author: myrrc

Cargo.toml

@@ -374,7 +374,8 @@ use_debug = "deny"
 
 [profile.release]
 codegen-units = 1
-# Turn LTO off, as it breaks when vortex-duckdb-ext is linked.
+# Our general performance should not be dependent on LTO since crates that use
+# Vortex may choose not to have LTO.
 lto = "off"
 
 [profile.release_debug]

vortex-duckdb/build.rs

@@ -7,7 +7,6 @@
 
 use std::env;
 use std::fs;
-use std::os::unix::fs::symlink;
 use std::path::Path;
 use std::path::PathBuf;
 use std::process::Command;
@@ -332,7 +331,7 @@ fn c2rust(crate_dir: &Path, duckdb_include_dir: &Path) {
 fn cpp(duckdb_include_dir: &Path) {
     cc::Build::new()
         .std("c++20")
-        .flags(["-Wall", "-Wextra", "-Wpedantic"])
+        .flags(["-Wall", "-Wextra", "-Wpedantic", "-Werror"])
         .cpp(true)
         .include(duckdb_include_dir)
         .include("cpp/include")
@@ -391,10 +390,21 @@ fn main() {
         DuckDBVersion::Commit(c) => println!("cargo:info=Using DuckDB commit: {c}"),
     }
 
+    let has_debug_env =
+        env::var("VX_DUCKDB_DEBUG").is_ok_and(|v| matches!(v.as_str(), "1" | "true"));
+    let build_type = match has_debug_env {
+        true => "debug",
+        false => "release",
+    };
+
     let crate_dir = PathBuf::from(env::var("CARGO_MANIFEST_DIR").unwrap());
-    let duckdb_dir = crate_dir.join("duckdb");
-    let out_dir = PathBuf::from(env::var("OUT_DIR").unwrap());
-    let library_dir = out_dir.join(format!("duckdb-lib-{version}"));
+    let duckdb_dir = crate_dir.join(build_type).join("duckdb");
+    // Cargo has changed OUT_DIR behaviour so for every branch and build we have
+    // a different directory e.g.
+    // ~/vortex/target/release/build/vortex-duckdb-b6bc1fb73230910e/out/duckdb-lib-v1.5.2
+    // We don't want this since artifacts are the same.
+    // We can't use CARGO_TARGET_DIR since it's out of tree.
+    let library_dir = duckdb_dir.join(format!("duckdb-lib-{version}"));
 
     let library_dir_str = library_dir.display();
     println!("cargo:rustc-link-search=native={library_dir_str}");
@@ -415,7 +425,7 @@ fn main() {
     // Alternatively, set LD_LIBRARY_PATH (Linux) or DYLD_LIBRARY_PATH (macOS) at runtime.
     println!("cargo:lib_dir={library_dir_str}");
 
-    let source_dir = out_dir.join(format!("duckdb-source-{version}"));
+    let source_dir = duckdb_dir.join(format!("duckdb-source-{version}"));
     let source_archive_url = match &version {
         DuckDBVersion::Release(v) => format!("{DUCKDB_SOURCE_RELEASE_URL}/v{v}.zip"),
         DuckDBVersion::Commit(c) => format!("{DUCKDB_SOURCE_COMMIT_URL}/{c}.zip"),
@@ -430,16 +440,6 @@ fn main() {
         extract(&source_archive_path, &source_dir);
     }
 
-    drop(fs::remove_file(&duckdb_dir));
-    drop(fs::remove_dir_all(&duckdb_dir));
-    symlink(&source_dir, &duckdb_dir).unwrap();
-
-    let has_debug_env =
-        env::var("VX_DUCKDB_DEBUG").is_ok_and(|v| matches!(v.as_str(), "1" | "true"));
-    let build_type = match has_debug_env {
-        true => "debug",
-        false => "release",
-    };
     println!("cargo:info=building DuckDB in {build_type} mode");
 
     if has_debug_env || matches!(version, DuckDBVersion::Commit(_)) {

vortex-duckdb/cpp/CMakeLists.txt

@@ -3,9 +3,8 @@
 
 # This CMake project is only used for IDE support (CLion, etc.).
 # See build.rs for the actual build definition.
-#
 # Prerequisites: Run `cargo build -p vortex-duckdb` first to download DuckDB
-# source and create the symlink at ../duckdb.
+# source
 #
 # If your editor relies on a compilation database to enable LSP functionality,
 # you can generate it by running `cmake -DCMAKE_EXPORT_COMPILE_COMMANDS=ON` or
@@ -23,19 +22,19 @@ if (NOT CMAKE_BUILD_TYPE)
 endif()
 
 # Enable compiler warnings (matching build.rs flags).
-set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra -Wpedantic")
+set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wextra -Wpedantic -Werror")
+set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} -Wall -Wextra -Wpedantic -Werror -O3")
 
-# Find DuckDB include directory via the symlink created by build.rs.
-# The symlink points to target/duckdb-source-vX.Y.Z which contains duckdb-X.Y.Z/
-file(GLOB DUCKDB_DIRS "${CMAKE_CURRENT_SOURCE_DIR}/../duckdb/duckdb-*")
+# Find DuckDB include directory containing duckdb-source-vX.Y.Z which contains duckdb-X.Y.Z/
+file(GLOB DUCKDB_DIRS "${CMAKE_CURRENT_SOURCE_DIR}/../duckdb/duckdb-source-*/duckdb-*/")
 if(DUCKDB_DIRS)
     list(GET DUCKDB_DIRS 0 DUCKDB_DIR)
     set(DUCKDB_INCLUDE "${DUCKDB_DIR}/src/include")
     message(STATUS "Found DuckDB include: ${DUCKDB_INCLUDE}")
 else()
     message(FATAL_ERROR
         "DuckDB source not found at ../duckdb/duckdb-*\n"
-        "Run 'cargo build -p vortex-duckdb' first to download DuckDB and create the symlink."
+        "Run 'cargo build -p vortex-duckdb' first to download DuckDB"
     )
 endif()