Skip to content

Lock scheduler in GDB when launching functions#8629

Merged
myrrc merged 1 commit into
developfrom
myrrc/gdb-2
Jun 30, 2026
Merged

Lock scheduler in GDB when launching functions#8629
myrrc merged 1 commit into
developfrom
myrrc/gdb-2

Conversation

@myrrc

@myrrc myrrc commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Previously, when printing Id in GDB, thread have been changing constantly
and stack frame was lost. This PR resolves that.

@myrrc myrrc requested a review from a team June 30, 2026 16:00
@myrrc myrrc added the changelog/skip Do not list PR in the changelog label Jun 30, 2026
@myrrc myrrc requested a review from AdamGS June 30, 2026 16:00
@myrrc myrrc enabled auto-merge (squash) June 30, 2026 16:00
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
@codspeed-hq

codspeed-hq Bot commented Jun 30, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 4 improved benchmarks
❌ 3 regressed benchmarks
✅ 1588 untouched benchmarks
⏩ 4 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_bool_canonical_into[(1000, 10)] 15.9 µs 26.3 µs -39.65%
Simulation chunked_varbinview_canonical_into[(100, 100)] 224.4 µs 259.6 µs -13.55%
Simulation chunked_varbinview_into_canonical[(100, 100)] 271.5 µs 306.7 µs -11.48%
Simulation chunked_varbinview_into_canonical[(1000, 10)] 205.7 µs 169 µs +21.73%
Simulation bitwise_not_vortex_buffer_mut[128] 244.4 ns 215.3 ns +13.55%
Simulation bitwise_not_vortex_buffer_mut[1024] 304.7 ns 275.6 ns +10.58%
Simulation eq_i64_constant 319.1 µs 289.2 µs +10.33%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing myrrc/gdb-2 (5b0ac94) with develop (3077131)

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@myrrc myrrc merged commit 5d3be01 into develop Jun 30, 2026
68 checks passed
@myrrc myrrc deleted the myrrc/gdb-2 branch June 30, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/skip Do not list PR in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants