Skip to content

Decouple optional features from pulling vortex-file features for top crate#8642

Merged
AdamGS merged 2 commits into
developfrom
adamg/decouple-tokio-and-file-feature
Jul 2, 2026
Merged

Decouple optional features from pulling vortex-file features for top crate#8642
AdamGS merged 2 commits into
developfrom
adamg/decouple-tokio-and-file-feature

Conversation

@AdamGS

@AdamGS AdamGS commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Rationale for this change

vortex-files pull a lot of encodings which makes it a very big dependency.
Some systems only need the core APIs, but enabling "tokio", "zstd" or "object-store" currently pulls in the full vortex-file.

What changes are included in this PR?

Make the features of "vortex" use a weak link to "vortex-file", so it doesn't pull it in by default.

What APIs are changed? Are there any user-facing changes?

Some feature configurations will require adjustment.

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS requested review from a team, a10y, blaginin and robert3005 July 2, 2026 15:08
@AdamGS AdamGS added the changelog/chore A trivial change label Jul 2, 2026
@AdamGS AdamGS changed the title Decouple the tokio and files create features Decouple optional features from pulling vortex-file features for top crate Jul 2, 2026
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@codspeed-hq

codspeed-hq Bot commented Jul 2, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 6 improved benchmarks
❌ 2 regressed benchmarks
✅ 1587 untouched benchmarks
⏩ 4 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_bool_canonical_into[(1000, 10)] 22.6 µs 26.8 µs -15.84%
Simulation chunked_varbinview_into_canonical[(100, 100)] 271.6 µs 306.4 µs -11.36%
Simulation chunked_varbinview_opt_canonical_into[(1000, 10)] 206.3 µs 169.6 µs +21.59%
Simulation chunked_varbinview_into_canonical[(1000, 10)] 205.5 µs 169.3 µs +21.39%
Simulation chunked_varbinview_opt_into_canonical[(1000, 10)] 219.6 µs 183.4 µs +19.73%
WallTime cuda/bitpacked_u8/unpack/3bw[100M] 353.2 µs 300 µs +17.72%
Simulation compact_sliced[(4096, 90)] 866.7 ns 779.2 ns +11.23%
Simulation encode_varbin[(1000, 2)] 152.9 µs 138.7 µs +10.19%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing adamg/decouple-tokio-and-file-feature (8ebcf6a) with develop (b7b1408)

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@AdamGS AdamGS merged commit d9ee09f into develop Jul 2, 2026
93 of 98 checks passed
@AdamGS AdamGS deleted the adamg/decouple-tokio-and-file-feature branch July 2, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/chore A trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants