Remove execute_boolean fallback to arrow#8644
Conversation
Signed-off-by: Robert Kruszewski <github@robertk.io>
Polar Signals Profiling ResultsLatest Run
Powered by Polar Signals Cloud |
Benchmarks: PolarSignals ProfilingVortex (geomean): 1.074x ➖ How to read Verdict and Engines
datafusion / vortex-file-compressed (1.074x ➖, 0↑ 5↓)
No file size changes detected. |
Benchmarks: TPC-H SF=1 on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.986x ➖, 0↑ 0↓)
datafusion / vortex-compact (0.997x ➖, 0↑ 0↓)
datafusion / parquet (1.014x ➖, 0↑ 2↓)
datafusion / arrow (1.016x ➖, 0↑ 2↓)
duckdb / vortex-file-compressed (1.003x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.995x ➖, 0↑ 0↓)
duckdb / parquet (1.010x ➖, 0↑ 2↓)
duckdb / duckdb (0.998x ➖, 0↑ 0↓)
File Size Changes (10 files changed, -0.2% overall, 2↑ 8↓)
Totals:
|
Benchmarks: FineWeb NVMeVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.036x ➖, 0↑ 3↓)
datafusion / vortex-compact (0.993x ➖, 1↑ 0↓)
datafusion / parquet (1.008x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.015x ➖, 0↑ 1↓)
duckdb / vortex-compact (1.019x ➖, 0↑ 1↓)
duckdb / parquet (1.016x ➖, 0↑ 0↓)
File Size Changes (1 files changed, -0.0% overall, 0↑ 1↓)
Totals:
|
Benchmarks: TPC-DS SF=1 on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.019x ➖, 1↑ 1↓)
datafusion / vortex-compact (1.011x ➖, 0↑ 0↓)
datafusion / parquet (1.029x ➖, 0↑ 1↓)
duckdb / vortex-file-compressed (1.098x ➖, 0↑ 45↓)
duckdb / vortex-compact (1.062x ➖, 0↑ 19↓)
duckdb / parquet (1.017x ➖, 0↑ 3↓)
duckdb / duckdb (1.026x ➖, 1↑ 4↓)
File Size Changes (6 files changed, -0.0% overall, 2↑ 4↓)
Totals:
|
Merging this PR will not alter performance
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | chunked_varbinview_into_canonical[(1000, 10)] |
169.3 µs | 205.8 µs | -17.75% |
| ❌ | Simulation | chunked_varbinview_opt_canonical_into[(1000, 10)] |
169.6 µs | 206 µs | -17.66% |
| ❌ | Simulation | chunked_varbinview_opt_into_canonical[(1000, 10)] |
183.4 µs | 219.5 µs | -16.45% |
| ❌ | Simulation | slice_empty_vortex |
339.4 ns | 397.8 ns | -14.66% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[128] |
273.6 ns | 215.3 ns | +27.1% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[1024] |
333.9 ns | 275.6 ns | +21.17% |
| ⚡ | WallTime | cuda/bitpacked_u8/unpack/3bw[100M] |
353.2 µs | 298.8 µs | +18.21% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[2048] |
427.8 ns | 369.4 ns | +15.79% |
| ⚡ | Simulation | chunked_varbinview_into_canonical[(100, 100)] |
306.4 µs | 271.9 µs | +12.71% |
| ⚡ | Simulation | encode_varbin[(1000, 2)] |
152.9 µs | 138.7 µs | +10.21% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing rk/booleanfallback (9d409e3) with develop (d9ee09f)
Footnotes
-
15 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Benchmarks: FineWeb S3Verdict: No clear signal (environment too noisy confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.098x ➖, 0↑ 2↓)
datafusion / vortex-compact (1.001x ➖, 0↑ 0↓)
datafusion / parquet (1.018x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.024x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.004x ➖, 0↑ 0↓)
duckdb / parquet (1.075x ➖, 0↑ 0↓)
|
Benchmarks: Clickbench Sorted on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.981x ➖, 3↑ 2↓)
datafusion / parquet (0.981x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (0.916x ➖, 8↑ 1↓)
duckdb / parquet (0.894x ✅, 7↑ 0↓)
duckdb / duckdb (0.895x ✅, 4↑ 0↓)
File Size Changes (201 files changed, +0.0% overall, 106↑ 95↓)
Totals:
|
Benchmarks: Statistical and Population GeneticsVerdict: No clear signal (low confidence) How to read Verdict and Engines
duckdb / vortex-file-compressed (1.063x ➖, 0↑ 4↓)
duckdb / vortex-compact (1.114x ❌, 0↑ 7↓)
duckdb / parquet (1.113x ❌, 0↑ 5↓)
File Size Changes (1 files changed, +0.0% overall, 1↑ 0↓)
Totals:
|
Benchmarks: Random AccessVortex (geomean): 1.029x ➖ How to read Verdict and Engines
unknown / unknown (1.025x ➖, 0↑ 2↓)
|
Benchmarks: TPC-H SF=10 on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.924x ➖, 2↑ 0↓)
datafusion / vortex-compact (0.935x ➖, 0↑ 0↓)
datafusion / parquet (0.942x ➖, 0↑ 0↓)
datafusion / arrow (0.919x ➖, 5↑ 0↓)
duckdb / vortex-file-compressed (0.940x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.954x ➖, 0↑ 0↓)
duckdb / parquet (0.970x ➖, 0↑ 0↓)
duckdb / duckdb (0.961x ➖, 0↑ 0↓)
File Size Changes (26 files changed, +0.0% overall, 12↑ 14↓)
Totals:
|
Benchmarks: Clickbench on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.066x ➖, 0↑ 10↓)
datafusion / parquet (1.018x ➖, 0↑ 1↓)
duckdb / vortex-file-compressed (1.049x ➖, 0↑ 9↓)
duckdb / parquet (1.060x ➖, 0↑ 16↓)
duckdb / duckdb (0.991x ➖, 1↑ 0↓)
File Size Changes (104 files changed, -0.0% overall, 50↑ 54↓)
Totals:
|
Benchmarks: TPC-H SF=1 on S3Verdict: No clear signal (environment too noisy confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.028x ➖, 1↑ 1↓)
datafusion / vortex-compact (1.183x ➖, 0↑ 6↓)
datafusion / parquet (1.072x ➖, 1↑ 5↓)
duckdb / vortex-file-compressed (1.051x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.019x ➖, 0↑ 0↓)
duckdb / parquet (1.057x ➖, 0↑ 0↓)
|
Benchmarks: Appian on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.005x ➖, 0↑ 0↓)
datafusion / parquet (0.992x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (0.998x ➖, 0↑ 0↓)
duckdb / parquet (1.001x ➖, 0↑ 0↓)
duckdb / duckdb (1.005x ➖, 0↑ 0↓)
File Size Changes (4 files changed, -0.0% overall, 3↑ 1↓)
Totals:
|
Benchmarks: TPC-H SF=10 on S3Verdict: No clear signal (environment too noisy confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.042x ➖, 0↑ 1↓)
datafusion / vortex-compact (1.046x ➖, 1↑ 2↓)
datafusion / parquet (1.021x ➖, 1↑ 2↓)
duckdb / vortex-file-compressed (0.928x ➖, 1↑ 0↓)
duckdb / vortex-compact (0.898x ➖, 0↑ 0↓)
duckdb / parquet (0.981x ➖, 0↑ 0↓)
|
Benchmarks: CompressionVortex (geomean): 1.004x ➖ How to read Verdict and Engines
unknown / unknown (1.004x ➖, 0↑ 0↓)
|
It's unclear why we left it, we implement the boolean logic on vortex boolean
arrays always