feat(vortex-bench): support vortex native geo types into SpatialBench, and wire into benchmark orchestrator#8623
Open
HarukiMoriarty wants to merge 2 commits into
Open
Conversation
Merging this PR will not alter performance
|
a3c046b to
790a0d7
Compare
69a4f90 to
bc74778
Compare
Signed-off-by: Nemo Yu <zyu379@wisc.edu>
Signed-off-by: Nemo Yu <zyu379@wisc.edu>
bc74778 to
8e0738a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wires vortex geo native format into SpatialBench, and wire into the
vx-bench/bench-orchestratorpipeline so it can be run end-to-end like the other benchmarks.Running command:
Limitation
BENCHMARK_ENGINES = { SPATIALBENCH: {DUCKDB} }.Performance
SF=1.0
SF=10
Takeaways: for now we do not have only pushdown to execute predicate in vortex kernel, so geo native types pay the tax of converting to geo-binary (talk to duckdb) but no gains, so in SF=10 vortex-native is less efficient compared with vortex-wkb.