From e72acdc98c7efa5ff5b6ecf3f65b12dbabf010f0 Mon Sep 17 00:00:00 2001 From: Frederic Branczyk Date: Tue, 30 Jun 2026 17:53:19 +0200 Subject: [PATCH] fix(vortex-bench): map gs:// scheme to gcs storage label url_scheme_to_storage only handled s3 and file, so benchmark runs against GCS (gs://) failed during setup with "unknown URL scheme: gs" before any query ran. Add a STORAGE_GCS constant and a gs arm. make_object_store already handles gs:// for the actual reads. Signed-off-by: Frederic Branczyk Co-Authored-By: Claude Opus 4.8 (1M context) --- vortex-bench/src/utils/constants.rs | 1 + vortex-bench/src/utils/file.rs | 2 ++ 2 files changed, 3 insertions(+) diff --git a/vortex-bench/src/utils/constants.rs b/vortex-bench/src/utils/constants.rs index c9f5ca4c442..959ad63b7f4 100644 --- a/vortex-bench/src/utils/constants.rs +++ b/vortex-bench/src/utils/constants.rs @@ -4,3 +4,4 @@ /// Storage type constants pub const STORAGE_NVME: &str = "nvme"; pub const STORAGE_S3: &str = "s3"; +pub const STORAGE_GCS: &str = "gcs"; diff --git a/vortex-bench/src/utils/file.rs b/vortex-bench/src/utils/file.rs index fb7ecc668fb..f05113963f7 100644 --- a/vortex-bench/src/utils/file.rs +++ b/vortex-bench/src/utils/file.rs @@ -161,11 +161,13 @@ pub fn resolve_data_url(remote_data_dir: Option<&str>, local_subdir: &str) -> Re /// - A storage type string ("s3", "nvme") /// - Or an error if the scheme is unknown pub fn url_scheme_to_storage(url: &Url) -> Result { + use super::constants::STORAGE_GCS; use super::constants::STORAGE_NVME; use super::constants::STORAGE_S3; match url.scheme() { STORAGE_S3 => Ok(STORAGE_S3.to_owned()), + "gs" => Ok(STORAGE_GCS.to_owned()), "file" => Ok(STORAGE_NVME.to_owned()), otherwise => { bail!("unknown URL scheme: {}", otherwise)