This repository was archived by the owner on Jul 26, 2024. It is now read-only.
Fix ensure pattern to support version numbers with more than one digit #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This fixes the pattern used for the ensure parameter.
At the moment only versions with a single digit at each position are allowed. The most recent version of Etherpad is
1.8.17and Puppet will fail withClass[Etherpad]: parameter 'ensure' expects an Etherpad::Ensure = Variant[Enum['absent', 'latest', 'present'], Pattern[/\A\d\.\d\.\d\Z/, /\A[a-fA-F0-9]{6,40}\Z/]]. With this PR multiple digits at each position are possible, ensuring future compatibility.This Pull Request (PR) fixes the following issues
n/a