Merge pull request #739 from Szparki/fix-group

Fix group ownership for pip.conf on FreeBSD

Author: smortex

REFERENCE.md

@@ -420,7 +420,7 @@ Data type: `String[1]`
 
 group owner of dotfile
 
-Default value: `'root'`
+Default value: `getvar('python::params::group')`
 
 ##### <a name="-python--dotfile--config"></a>`config`
 

manifests/dotfile.pp

@@ -26,7 +26,7 @@
   Enum['absent', 'present'] $ensure   = 'present',
   Stdlib::Absolutepath      $filename = $title,
   String[1]                 $owner    = 'root',
-  String[1]                 $group    = 'root',
+  String[1]                 $group    = getvar('python::params::group'),
   Stdlib::Filemode          $mode     = '0644',
   Hash                      $config   = {},
 ) {

spec/defines/dotfile_spec.rb

@@ -9,6 +9,16 @@
         facts
       end
 
+      let(:root_group) do
+        if facts[:os]['family'] == 'FreeBSD'
+          'wheel'
+        else
+          'root'
+        end
+      end
+
+      let(:pre_condition) { 'include python' }
+
       describe 'dotfile as' do
         context 'fails with empty string filename' do
           let(:title) { '' }
@@ -32,15 +42,15 @@
         context 'succeeds with filename in a non-existing path' do
           let(:title) { '/home/someuser/.pip/pip.conf' }
 
-          it { is_expected.to contain_exec('create /home/someuser/.pip/pip.conf\'s parent dir').with_command('install -o root -g root -d /home/someuser/.pip') }
+          it { is_expected.to contain_exec('create /home/someuser/.pip/pip.conf\'s parent dir').with_command("install -o root -g #{root_group} -d /home/someuser/.pip") }
           it { is_expected.to contain_file('/home/someuser/.pip/pip.conf').with_mode('0644') }
         end
 
         context 'succeeds when set owner' do
           let(:title) { '/home/someuser/.pip/pip.conf' }
           let(:params) { { owner: 'someuser' } }
 
-          it { is_expected.to contain_exec('create /home/someuser/.pip/pip.conf\'s parent dir').with_command('install -o someuser -g root -d /home/someuser/.pip') }
+          it { is_expected.to contain_exec('create /home/someuser/.pip/pip.conf\'s parent dir').with_command("install -o someuser -g #{root_group} -d /home/someuser/.pip") }
           it { is_expected.to contain_file('/home/someuser/.pip/pip.conf').with_owner('someuser') }
         end