adding options to control state of single firewall profiles #167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Currently, the ensure parameter controls both the windows firewall service and enables/disables the 3 firewall profiles "Domain", "Public" and "Standard". As described in linked issues, Microsoft does not recommend to stop the firewall service, but disable all firewall profiles instead. Furthermore, Windows Server 2025 does not even allow to disable the service ("Failed to transition the MpsSvc service to the SERVICE_STOPPED state. Detail: Failed to open a handle to the service: Access is denied.").
This PR adds new parameters to control firewall profiles separately from the service state:
The behavior is backwards compatible, i.e. if the 3 parameters are unset, the 3 profiles will be enabled/disabled equivalently to the service.
This Pull Request (PR) fixes the following issues
Fixes #54
Fixes #55