Skip to content

Conversation

@dermsd
Copy link

@dermsd dermsd commented Oct 17, 2025

Pull Request (PR) description

Currently, the ensure parameter controls both the windows firewall service and enables/disables the 3 firewall profiles "Domain", "Public" and "Standard". As described in linked issues, Microsoft does not recommend to stop the firewall service, but disable all firewall profiles instead. Furthermore, Windows Server 2025 does not even allow to disable the service ("Failed to transition the MpsSvc service to the SERVICE_STOPPED state. Detail: Failed to open a handle to the service: Access is denied.").

This PR adds new parameters to control firewall profiles separately from the service state:

  • enable_domain_profile
  • enable_public_profile
  • enable_standard_profile

The behavior is backwards compatible, i.e. if the 3 parameters are unset, the 3 profiles will be enabled/disabled equivalently to the service.

This Pull Request (PR) fixes the following issues

Fixes #54
Fixes #55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make disabling the firewall service optional Cant disable firewall profiles

1 participant