Skip to content

Conversation

camc314
Copy link

@camc314 camc314 commented May 14, 2025

$ hyperfine --warmup 3 'npm run lint' 'npm run lint:ox'                                                                                        
Benchmark 1: npm run lint
  Time (mean ± σ):     718.5 ms ±  11.7 ms    [User: 697.0 ms, System: 138.4 ms]
  Range (min … max):   693.1 ms … 738.2 ms    10 runs
 
Benchmark 2: npm run lint:ox
  Time (mean ± σ):     233.6 ms ±  12.0 ms    [User: 162.8 ms, System: 47.5 ms]
  Range (min … max):   213.0 ms … 263.9 ms    12 runs
 
Summary
  npm run lint:ox ran
    3.08 ± 0.17 times faster than npm run lint

oxlint appears to run 3x faster than eslint (with eslint using cache)

Copy link

coderabbitai bot commented May 14, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@camc314
Copy link
Author

camc314 commented May 14, 2025

hey all, oxlint doesn't support this:

core/eslint.config.js

Lines 164 to 169 in 35785f3

{
files: ['packages/compiler-sfc/src/**'],
rules: {
'import-x/no-nodejs-modules': ['error', { allow: builtinModules }],
},
},

part of the lint rule - what's the purpose of this lint rule? it looks like it's just enforcing that nodejs modules are imported like

import 'path'

and not

import 'node:path

thanks

@camc314 camc314 changed the title feat: add oxlint feat: add oxlint linting along side eslint May 14, 2025
Copy link

github-actions bot commented May 15, 2025

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 84 kB 29.8 kB 26.3 kB
runtime-dom.global.prod.js 104 kB 39.1 kB 35.3 kB
vue.global.prod.js 162 kB 59.3 kB 52.9 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47.2 kB 18.4 kB 16.9 kB
createApp 56 kB 21.6 kB 19.7 kB
createApp + vaporInteropPlugin 68.6 kB 25.9 kB 23.6 kB
createVaporApp 20.9 kB 8.26 kB 7.57 kB
createSSRApp 60.3 kB 23.3 kB 21.3 kB
defineCustomElement 61 kB 23.1 kB 21.1 kB
overall 70.5 kB 26.8 kB 24.4 kB

Copy link

pkg-pr-new bot commented May 15, 2025

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13326

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13326

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13326

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13326

@vue/compiler-vapor

npm i https://pkg.pr.new/@vue/compiler-vapor@13326

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13326

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13326

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13326

@vue/runtime-vapor

npm i https://pkg.pr.new/@vue/runtime-vapor@13326

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13326

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13326

vue

npm i https://pkg.pr.new/vue@13326

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13326

commit: 5802229

@edison1105 edison1105 changed the base branch from main to minor May 15, 2025 07:53
@edison1105 edison1105 changed the base branch from minor to main May 15, 2025 08:28
@edison1105 edison1105 changed the base branch from main to minor May 15, 2025 08:29
@edison1105 edison1105 changed the base branch from minor to main May 15, 2025 08:35
@edison1105 edison1105 changed the base branch from main to minor May 15, 2025 08:35
@camc314 camc314 changed the title feat: add oxlint linting along side eslint feat: migrate linting to oxlint Jun 2, 2025
@edison1105
Copy link
Member

@camc314
Thanks for this PR, but I think you should create the branch based on the minor branch instead of main.

Copy link

netlify bot commented Sep 10, 2025

Deploy Preview for vue-sfc-playground failed. Why did it fail? →

Name Link
🔨 Latest commit 4c0d013
🔍 Latest deploy log https://app.netlify.com/projects/vue-sfc-playground/deploys/68c10f8ca0956f0007e6dd8d

@camc314 camc314 marked this pull request as ready for review September 10, 2025 03:32
@camc314
Copy link
Author

camc314 commented Sep 10, 2025

@camc314 Thanks for this PR, but I think you should create the branch based on the minor branch instead of main.

yep, thank you. should be fixed now 🤞

@edison1105
Copy link
Member

edison1105 commented Sep 10, 2025

Those deployments failed just related to [email protected], pin [email protected] will resolve.

@camc314
Copy link
Author

camc314 commented Sep 10, 2025

Those deployments failed just related to [email protected], pin [email protected] will resolve.

I can't work out the netifly failure? It should be pinned to 4.47.0 here? And yet it's still failing

https://github.com/camc314/core/blob/15aa50bb88aa3026c0c91115c93e215d20c226e6/package.json#L99

@edison1105
Copy link
Member

@camc314 uh, sorry, should be [email protected].

@camc314
Copy link
Author

camc314 commented Sep 10, 2025

Thanks! looks like it's working now

@camc314
Copy link
Author

camc314 commented Sep 10, 2025

CI is failing, i've put up a fix on oxc side oxc-project/oxc#13644 the fix that it's running is technically unsafe (makes typecheck fail)

@TheAlexLichter
Copy link

Ci is passing now 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants