-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
feat: migrate linting to oxlint #13326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: minor
Are you sure you want to change the base?
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal). Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
hey all, oxlint doesn't support this: Lines 164 to 169 in 35785f3
part of the lint rule - what's the purpose of this lint rule? it looks like it's just enforcing that nodejs modules are imported like
and not
thanks |
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/compiler-vapor
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/runtime-vapor
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
b413638
to
d22eb83
Compare
@camc314 |
d22eb83
to
60fba76
Compare
❌ Deploy Preview for vue-sfc-playground failed. Why did it fail? →
|
yep, thank you. should be fixed now 🤞 |
Those deployments failed just related to |
1d5e135
to
c4e9858
Compare
I can't work out the netifly failure? It should be pinned to 4.47.0 here? And yet it's still failing https://github.com/camc314/core/blob/15aa50bb88aa3026c0c91115c93e215d20c226e6/package.json#L99 |
@camc314 uh, sorry, should be [email protected]. |
Thanks! looks like it's working now |
CI is failing, i've put up a fix on oxc side oxc-project/oxc#13644 the fix that it's running is technically unsafe (makes typecheck fail) |
5802229
to
b36fd05
Compare
b36fd05
to
b321a3f
Compare
Ci is passing now 👏 |
oxlint appears to run 3x faster than eslint (with eslint using cache)