Skip to content

incorrect types for nested refs in storeToRefs with Vue 3.5 #2769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Glandos opened this issue Sep 11, 2024 · 1 comment
Closed

incorrect types for nested refs in storeToRefs with Vue 3.5 #2769

Glandos opened this issue Sep 11, 2024 · 1 comment
Labels
bug Something isn't working contribution welcome typescript This issue is related to typings

Comments

@Glandos
Copy link

Glandos commented Sep 11, 2024

Reproduction

https://play.pinia.vuejs.org/#eNqNVU1z2jAQ/SsaXyAMSGFI0xkKDG0nh/aQdpIcfTH2AqLWx0gyoUP5711Lxqg0ZPDJ2n2772l3vd4nn7Wm2wqScTKxueHaEQuu0qTM5GqaJs6mySyVXGhlHNmTysKzUwbIgSyNEqRDWa4q6cBQZzsR0NaoF/UES9tiNZc8Q1AqcyUtMvlM0zZp9yaVrNdLZVcbpcG43zeIyVxlx2SfSoIPHxNZiQWYT+G8ic4H8ucqWCp7LEV+ZKQhfS3JEx91BU4UP7kmYT+irWOCp98gZqeQt53X6sY+1MKDxrrCtUos7jQudvdUTKzmhIWmYigeHAhdZg7wRMhkUTmn5OxRuTWXqwlrznVQBEz6SejpQGSabqySOCpebdo4cELa9qQJzlJ9TpO1c9qOGcsLiWEFlHxrqATHpBZsjjBmcG64gEGhxHxEP9A7VnDrYjMFKwYLo14tztcGifoRDUPjFszAgCzAgLmW9iwspj5zXab3kxwImX+/DPWcBWydUqUdZJpfqzOOmd/TezpkJV8wJGIc9e3+K8igAHFN9iN0fkuHd/Sjz7odNUlFnbVOip/JAZvvLM7bkq/OWp8roXkJ5od2HOfxnxHIylK9fvc2ZypoJeZryH+9Yd/YXVD904DvQHQtl5kVuOB+eH6EHb63TqGKqmzG7YLzCawqq1pjgH2pZIGyI5xX+81PMn4GL/Zh50Da46Vqob4aHu/L/PWdq5/kjugoquJpR2IJ2x1ZwJLLs3163JEtyMCydSK7X5+w886wCdqVPI0TdjsNZ6dPujdkOgsiQwhHLObt3uKKONo2jW2ItpO1WTLBted9sjk0foO/CSOjPYQ3RVdy+Aty8yL7

Steps to reproduce the bug

Using storeToRefs returns a type with both a Ref and UnwrapRef.

Expected behavior

It should only returns UnwrapRef

Actual behavior

Both are returns, and Typescript throws some errors.

Additional information

Maybe linked to #2767

Maybe caused by vuejs/core#11442
@posva posva changed the title storeToRefs is broken with Vue 3.5 incorrect types for nested refs in storeToRefs with Vue 3.5 Sep 11, 2024
@posva posva added bug Something isn't working contribution welcome typescript This issue is related to typings labels Sep 11, 2024
@github-project-automation github-project-automation bot moved this to 🆕 Triaging in Pinia Roadmap Sep 11, 2024
@posva
Copy link
Member

posva commented Sep 26, 2024

Fixed with 623e5a0

@posva posva closed this as completed Sep 26, 2024
@github-project-automation github-project-automation bot moved this from 🆕 Triaging to ✅ Done in Pinia Roadmap Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working contribution welcome typescript This issue is related to typings
Projects
Pinia Roadmap
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Glandos @posva