-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling Loading State for async route components. #2445
Comments
It seems to be working on my end. You will have to provide more information about what not working means 😄 |
my bad 👍 what i mean is the route is successfully loaded but the Loading.vue component is not even mounted, I expected to see "I WAS HERE" in the console and it didnot happen. This is not the case when using the same syntax with async components not routes, I can see "I WAS HERE" in the console in that case, hope I explained the problem more, thank you |
Have you seen #2140 ? |
Thank you Posva this helps, but why this pull request is not merged ? will this be changed ? is it not advised to use this ? |
We wanted to wait for a review
On Tue 23 Oct 2018 at 10:44, Abdalla Nayer ***@***.***> wrote:
Thank you Posva this helps, but why this pull request is not merged ? will
this be changed ? is it not advised to use this ?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#2445 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAoicflLGgIbzLBy67ZYd905Ibw9LTZTks5untcEgaJpZM4Xzbxv>
.
--
Eduardo San Martin Morote
|
Also need this feature, hoped it been merged |
Version
3.0.1
Reproduction link
https://codesandbox.io/s/8xn8jn4xl9
Steps to reproduce
Click on Foo and check the network tab and console
What is expected?
Based on what is mentioned in the documentation
https://vuejs.org/v2/guide/components-dynamic-async.html#Handling-Loading-State
That this should work as well for async route components since 2.4.0
What is actually happening?
It is not working on async route components but working well on async components
The text was updated successfully, but these errors were encountered: