-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[aria.js]: "abstract role" not added to index #105
Comments
Related to #104. I'm getting the feeling that the current approach to generate our abstracted data by looking at innerHTML or innerText for various elements might be something worth discussing. |
For completeness: this is already "broken" in the 1.2 REC. |
While working on #106, I found the bug: aria.js uses querySelectorAll instead of querySelector here: Lines 241 to 245 in 2fe4fe2
so the if-check immediately after will always fail. |
However, besides obviously introducing many changes, it seems to break a lot of things (tbd exactly how). |
Extracts the rdef rewrite to function in global scope. Unfortunately we cannot re-use the sdef/pdef setup since it creates different HTML (and also #105). test.sh run is clean.
The issue w3c/aria#2082 made me look at https://w3c.github.io/aria/#role_definitions
While the line
https://github.com/w3c/aria-common/blob/2fe4fe20cffad6314bddb6d6b9ed09c63c087cfb/script/aria.js#L265C6-L265C6
suggests we add a parenthetical "abstract role", this appears to be broken, i.e., none of the abstract roles have this parenthetical.
The text was updated successfully, but these errors were encountered: