Skip to content

Infrastructure: Pull updated user agent strings for link-checker #3270

@howard-e

Description

@howard-e

This seems good enough, and will fix the bug in the short term, but will probably break again in a few months.

Certainly true.

I did a little research and ran into https://www.npmjs.com/package/user-agents - a package that someone has automated to collect the most popular user agents used on their own websites and it can generate "always up to date" user agents. We may want to look into using this package instead.

After a bit more research and a comment from @howard-e - https://github.com/DavideViolante/useragents-me-api/ looks like a much better choice

Not so much a fan for adding an extra lib for this small use case. Agreed on making this more future-proof, with the hardcoded string as a fallback. Fetching from the source site of that lib (specifically https://www.useragents.me/#most-common-desktop-useragents) is a good enough option to do in the future, to move this PR along.

Originally posted by @howard-e in #3264 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    InfrastructureRelated to maintaining task force and repo operations, processes, systems, documentationenhancementAny addition or improvement that doesn't fix a code bug or prose inaccuracygood first issueIssue with Straightforward resolution; could be good learning experience for new contributors

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions