Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When generating a 'default' manifest (where there wasn't any linked), manifest_url doesn't exist #1111

Closed
dmurph opened this issue Feb 29, 2024 · 2 comments

Comments

@dmurph
Copy link
Collaborator

dmurph commented Feb 29, 2024

I don't think there is an explicit problem here, as when generating the default manifest, nothing that uses the manifest_url is actually used (we just create the start_url, id, and scope). But many places reference this url in the algorithms, and in this case it doesn't exist.

@christianliebel christianliebel changed the title When generating a 'default' manifest (where there wasn't any linked), manifest_url doesn't exit When generating a 'default' manifest (where there wasn't any linked), manifest_url doesn't exist Mar 20, 2025
@marcoscaceres
Copy link
Member

marcoscaceres commented Mar 20, 2025

Ok... so we need to make it clear that when there is no link relationship, there's still the processed manifest that gets generated and applied. And that a user agent can also override the defaults.

@marcoscaceres
Copy link
Member

Closing in favor or #784

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants